Merge lp:~ken-vandine/libunity/lp_1058198 into lp:libunity

[Ken VanDine]

Make sender wrap the title property and set the subtitle in the
constructor. (LP: #1058198)

Make sender wrap the title property and set the subtitle in the
constructor. (LP: #1058198)

[Michal Hruby (mhr3)]

9 + public string sender {
10 + get { return title; }
11 + set { title = value; }
12 + }

Why is the sender even there if it's not used? I'd normally say remove it completely and use title directly, but we're in API freeze now, so let's leave the sender property there unused. Therefore:

 Object (title: sender, ...);

review: Needs Fixing

[lp:~ken-vandine/libunity/lp_1058198]

183. By Ken VanDine on 2012-10-01

Leave the sender property unused.

[Ken VanDine (ken-vandine)]

> 9 + public string sender {
> 10 + get { return title; }
> 11 + set { title = value; }
> 12 + }
>
> Why is the sender even there if it's not used? I'd normally say remove it
> completely and use title directly, but we're in API freeze now, so let's leave
> the sender property there unused. Therefore:
>
> Object (title: sender, ...);

Yeah, that is why I didn't remove it. I updated to match your suggestion.

[lp:~ken-vandine/libunity/lp_1058198]

184. By Ken VanDine on 2012-10-01

don't make sender wrap title, just leave it unused.

[Michal Hruby (mhr3)]

+1

review: Approve

=== modified file 'src/unity-previews.vala'
--- src/unity-previews.vala	2012-09-17 17:27:42 +0000
+++ src/unity-previews.vala	2012-10-01 14:27:30 +0000
@@ -529,11 +529,11 @@
   }
 
   public SocialPreview (string sender,
-                             string title,
+                             string subtitle,
                              string content,
                              Icon? avatar)
   {
-    Object (sender: sender, title: title, content: content,
+    Object (title: sender, subtitle: subtitle, content: content,
             avatar: avatar);
   }