Merge lp:~ken-vandine/libfriends/lp1194211 into lp:libfriends

Proposed by Ken VanDine
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 83
Merged at revision: 83
Proposed branch: lp:~ken-vandine/libfriends/lp1194211
Merge into: lp:libfriends
Diff against target: 60 lines (+10/-13)
3 files modified
configure.ac (+1/-11)
debian/changelog (+8/-0)
debian/control (+1/-2)
To merge this branch: bzr merge lp:~ken-vandine/libfriends/lp1194211
Reviewer Review Type Date Requested Status
Robert Bruce Park Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+226155@code.launchpad.net

Commit message

Use valadoc-1.0 to get vapidir when building docs so we can clean up build depends. Build depend on valac instead of valac-0.18 and dropped libvala-0.18-dev (LP: #1194211)

Description of the change

Use valadoc-1.0 to get vapidir when building docs so we can clean up build depends. Build depend on valac instead of valac-0.18 and dropped libvala-0.18-dev (LP: #1194211)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Looks fine to me, let's put this in a silo for testing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2013-10-24 15:28:15 +0000
3+++ configure.ac 2014-07-09 15:20:41 +0000
4@@ -135,16 +135,6 @@
5 AC_SUBST(BASE_CFLAGS)
6 AC_SUBST(BASE_LIBS)
7
8-
9-# valadoc only looks in the vapidir for libvala-0.14 but we need
10-# libvala-0.16 or libvala-0.18. This checks for either libvala dev
11-# package and sets the package to check for to set the vapidir
12-# if documentation is enabled
13-PKG_CHECK_MODULES([VALADEV], [libvala-0.18],
14- [LIBVALADEVPKG="libvala-0.18"],
15- [PKG_CHECK_MODULES([VALADEV], [libvala-0.16],
16- [LIBVALADEVPKG="libvala-0.16"])])
17-
18 ###########################
19 # Documentation
20 ###########################
21@@ -168,7 +158,7 @@
22 ])
23
24 AS_IF([test "x$enable_docs" = "xyes" -a "x$have_valadoc" = "xyes"], [
25- VALADOCVAPIDIR=`$PKG_CONFIG --variable=vapidir $LIBVALADEVPKG`
26+ VALADOCVAPIDIR=`$PKG_CONFIG --variable=vapidir valadoc-1.0`
27 AC_SUBST(VALADOCVAPIDIR)
28 ])
29
30
31=== modified file 'debian/changelog'
32--- debian/changelog 2013-11-08 17:13:17 +0000
33+++ debian/changelog 2014-07-09 15:20:41 +0000
34@@ -1,3 +1,11 @@
35+libfriends (0.1.2+14.04.20131108.1-0ubuntu2) UNRELEASED; urgency=medium
36+
37+ * debian/control
38+ - build depend on valac instead of valac-0.18 and dropped
39+ libvala-0.18-dev (LP: #1194211)
40+
41+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 09 Jul 2014 09:12:54 -0400
42+
43 libfriends (0.1.2+14.04.20131108.1-0ubuntu1) trusty; urgency=low
44
45 [ Colin Watson ]
46
47=== modified file 'debian/control'
48--- debian/control 2013-11-07 14:47:35 +0000
49+++ debian/control 2014-07-09 15:20:41 +0000
50@@ -21,9 +21,8 @@
51 libgtk-3-dev,
52 libgtkspell3-3-dev,
53 libjson-glib-dev,
54- libvala-0.18-dev,
55 python3-mock,
56- valac-0.18,
57+ valac,
58 xvfb,
59 Standards-Version: 3.9.4
60 Section: libs

Subscribers

People subscribed via source and target branches

to all changes: