Merge lp:~ken-vandine/libdbusmenu/lp_862989 into lp:libdbusmenu/0.5

Proposed by Ken VanDine on 2011-09-30
Status: Merged
Approved by: Ted Gould on 2011-10-12
Approved revision: 341
Merged at revision: 343
Proposed branch: lp:~ken-vandine/libdbusmenu/lp_862989
Merge into: lp:libdbusmenu/0.5
Diff against target: 12 lines (+1/-1)
1 file modified
libdbusmenu-glib/client.c (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/libdbusmenu/lp_862989
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve on 2011-10-03
DBus Menu Team 2011-09-30 Pending
Review via email: mp+77711@code.launchpad.net

Description of the change

id of 0 in dbusmenu_client_send_about_to_show is valid, and used in appindicators like nm-applet (LP: #862989)

To post a comment you must log in.
Andrea Cimitan (cimi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/client.c'
2--- libdbusmenu-glib/client.c 2011-09-29 19:33:58 +0000
3+++ libdbusmenu-glib/client.c 2011-09-30 14:26:24 +0000
4@@ -1610,7 +1610,7 @@
5 dbusmenu_client_send_about_to_show(DbusmenuClient * client, gint id, void (*cb)(gpointer data), gpointer cb_data)
6 {
7 g_return_if_fail(DBUSMENU_CLIENT(client));
8- g_return_if_fail(id > 0);
9+ g_return_if_fail(id >= 0);
10
11 DbusmenuClientPrivate * priv = DBUSMENU_CLIENT_GET_PRIVATE(client);
12 g_return_if_fail(priv != NULL);

Subscribers

People subscribed via source and target branches