The Me Menu

Merge lp:~ken-vandine/indicator-me/lp_754524 into lp:indicator-me

  1. lp_754524
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Ted Gould
Approved revision: 146
Merged at revision: 145
Proposed branch: lp:~ken-vandine/indicator-me/lp_754524
Merge into: lp:indicator-me
Diff against target: 30 lines (+3/-3)
2 files modified
src/indicator-me.c (+1/-1)
src/me-service-dbus.c (+2/-2)
To merge this branch: bzr merge lp:~ken-vandine/indicator-me/lp_754524
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+57713@code.launchpad.net

Description of the change

Pass the username as a g_variant on the UserChanged signal (LP: #754524)

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/indicator-me.c'
2--- src/indicator-me.c 2011-04-04 16:47:54 +0000
3+++ src/indicator-me.c 2011-04-14 15:46:27 +0000
4@@ -179,7 +179,7 @@
5 username_cb (GObject * object, GAsyncResult * res, gpointer user_data)
6 {
7 GError * error = NULL;
8- gchar * username;
9+ gchar * username = NULL;
10 GVariant * result;
11
12 IndicatorMe * self = INDICATOR_ME (user_data);
13
14=== modified file 'src/me-service-dbus.c'
15--- src/me-service-dbus.c 2011-01-13 20:37:08 +0000
16+++ src/me-service-dbus.c 2011-04-14 15:46:27 +0000
17@@ -310,11 +310,11 @@
18 INDICATOR_ME_SERVICE_DBUS_OBJECT,
19 INDICATOR_ME_SERVICE_DBUS_INTERFACE,
20 "UserChanged",
21- NULL,
22+ g_variant_new("(s)", username),
23 &error);
24
25 if (error != NULL) {
26- g_error("Unable to send UserChanged signal: %s", error->message);
27+ g_warning("Unable to send UserChanged signal: %s", error->message);
28 g_error_free(error);
29 return;
30 }

Subscribers

People subscribed via source and target branches