The Me Menu

Merge lp:~ken-vandine/indicator-me/lp_739319 into lp:indicator-me

  1. lp_739319
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Ted Gould
Approved revision: 139
Merged at revision: 139
Proposed branch: lp:~ken-vandine/indicator-me/lp_739319
Merge into: lp:indicator-me
Diff against target: 20 lines (+1/-2)
1 file modified
src/indicator-me.c (+1/-2)
To merge this branch: bzr merge lp:~ken-vandine/indicator-me/lp_739319
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Ted Gould (community) Approve
Review via email: mp+55367@code.launchpad.net

Description of the change

A g_warning here seems harmless and it prevents the crash reported in bug 739319

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/indicator-me.c'
2--- src/indicator-me.c 2011-03-10 17:53:09 +0000
3+++ src/indicator-me.c 2011-03-29 16:06:40 +0000
4@@ -189,7 +189,7 @@
5 g_return_if_fail(status_proxy != NULL);
6
7 if (error != NULL) {
8- g_error("Could not get the username %s", error->message);
9+ g_warning("Could not get the username %s", error->message);
10 g_error_free(error);
11 return;
12 }
13@@ -217,7 +217,6 @@
14 } else {
15 gtk_widget_hide(GTK_WIDGET(label));
16 }
17-
18 }
19
20 static GtkLabel *

Subscribers

People subscribed via source and target branches