lp:~ken-vandine/ido/lp_867649

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:ido/0.3 at revision 99

Canonical Desktop Experience Team: Pending requested 2012-01-11

Diff: 14 lines (+4/-0)

1 file modified

src/idooffscreenproxy.c (+4/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #867649: unity-panel-service crashed with SIGSEGV in gdk_window_new()

Medium

Fix Released

Link a bug report

Related blueprints

99. By Ken VanDine on 2012-01-11

Patch from ~covox (LP: #867649)

In method ido_offscreen_proxy_realize(), a call is made to gdk_screen_get_rgba_visual() to get a GdkVisual handle, which is then passed as part of a GdkWindowAttr structure to gdk_window_new().

What's not taken into account is that gdk_screen_get_rgba_visual() will return NULL if RGBA isn't supported by the destination window manager (e.g. if someone turned the Composite extension off). In this case, as the field is always marked as valid for use (GDK_WA_VISUAL), gdk_window_new will fall over.

Attached is a patch to fall back on gdk_screen_get_system_visual() if RGBA isn't available. With this, unity-panel-service no longer crashes after interacting with the Sound indicator if the Composite extension is switched off.

98. By Ken VanDine on 2011-12-14

removed deprecations from gtk3 and fixed sizing issues with idemessagedialog (LP: #888392)

97. By Ted Gould on 2011-10-13

0.3.1

96. By Ted Gould on 2011-10-12

Fixes for ARM

95. By Michal Hruby on 2011-10-03

Merge lp:~mhr3/ido/bug-865122

94. By Ted Gould on 2011-09-28

0.3.0

93. By Ted Gould on 2011-09-20

0.2.93

92. By Ted Gould on 2011-09-16

Ignoring m4

91. By Ted Gould on 2011-09-16

Update Autotools and remove Shave

90. By Ted Gould on 2011-09-16

Fix the calendar item