Merge lp:~ken-vandine/gwibber/lp_938667 into lp:gwibber

Proposed by Ken VanDine
Status: Merged
Merged at revision: 1342
Proposed branch: lp:~ken-vandine/gwibber/lp_938667
Merge into: lp:gwibber
Diff against target: 12 lines (+1/-1)
1 file modified
gwibber/microblog/plugins/facebook/gtk/facebook/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/gwibber/lp_938667
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+103900@code.launchpad.net

Description of the change

facebook: Don't crash on unicode characters in a username (LP: #938667)

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Screw Unicode; seems harmless.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gwibber/microblog/plugins/facebook/gtk/facebook/__init__.py'
2--- gwibber/microblog/plugins/facebook/gtk/facebook/__init__.py 2012-03-07 21:17:19 +0000
3+++ gwibber/microblog/plugins/facebook/gtk/facebook/__init__.py 2012-04-27 15:12:19 +0000
4@@ -158,7 +158,7 @@
5 if isinstance(acct, dict):
6 if acct.has_key("id") and acct.has_key("name"):
7 self.account["uid"] = acct["id"]
8- self.account["username"] = acct["name"]
9+ self.account["username"] = acct["name"].encode("utf-8")
10 saved = self.dialog.on_edit_account_save()
11 else:
12 print "Failed"