Merge lp:~ken-vandine/gsettings-ubuntu-touch-schemas/dialpad_sounds into lp:gsettings-ubuntu-touch-schemas
Proposed by
Ken VanDine
| Status: | Merged |
|---|---|
| Approved by: | Sebastien Bacher |
| Approved revision: | 45 |
| Merged at revision: | 46 |
| Proposed branch: | lp:~ken-vandine/gsettings-ubuntu-touch-schemas/dialpad_sounds |
| Merge into: | lp:gsettings-ubuntu-touch-schemas |
| Diff against target: |
13 lines (+4/-0) 1 file modified
accountsservice/com.ubuntu.touch.AccountsService.Sound.xml (+4/-0) |
| To merge this branch: | bzr merge lp:~ken-vandine/gsettings-ubuntu-touch-schemas/dialpad_sounds |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Sebastien Bacher (community) | Approve | ||
| Gustavo Pichorim Boiko | Pending | ||
|
Review via email:
|
|||
Commit message
Added an AccountsService boolean setting for DialpadSoundsEn
Description of the change
Added an AccountsService boolean setting for DialpadSoundsEn
To post a comment you must log in.
Revision history for this message
| Sebastien Bacher (seb128) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Sebastien Bacher (seb128) wrote | # |
Revision history for this message
| Ken VanDine (ken-vandine) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks, the description is not very useful there ... I guess it's a boolean value indicating if the diapad buttons should make a sound? Could you rework the commit message to be more descriptive? "setting for DialpadSounds" could be as well a filename of the sound to use than an on/off value...