Merge lp:~ken-vandine/friends/service_refresh_on_account_created into lp:friends

Proposed by Ken VanDine
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 199
Merged at revision: 198
Proposed branch: lp:~ken-vandine/friends/service_refresh_on_account_created
Merge into: lp:friends
Diff against target: 33 lines (+15/-0)
2 files modified
debian/changelog (+6/-0)
service/src/service.vala (+9/-0)
To merge this branch: bzr merge lp:~ken-vandine/friends/service_refresh_on_account_created
Reviewer Review Type Date Requested Status
Robert Bruce Park Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+159467@code.launchpad.net

Commit message

Initiate a refresh after a new account gets created

Description of the change

Initiate a refresh after a new account gets created

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:199
http://jenkins.qa.ubuntu.com/job/friends-ci/41/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/friends-raring-amd64-ci/41

Click here to trigger a rebuild:
http://s-jenkins:8080/job/friends-ci/41/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Works great!

As an aside, testing this was the first time that I've deleted/created UOA accounts *while friends-app was running* (usually I just watch debug messages from friends-service and output from debug_slave.py), *very* slick to see the messages disappear and reappear instantly as the account is deleted and created ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-17 05:03:07 +0000
3+++ debian/changelog 2013-04-17 18:27:22 +0000
4@@ -1,3 +1,9 @@
5+friends (0.1.3daily13.04.17~13.04-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * Initiate a refresh after a new account gets created
8+
9+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 17 Apr 2013 11:21:09 -0400
10+
11 friends (0.1.3daily13.04.17~13.04-0ubuntu1) raring; urgency=low
12
13 [ Robert Bruce Park ]
14
15=== modified file 'service/src/service.vala'
16--- service/src/service.vala 2013-04-05 18:46:52 +0000
17+++ service/src/service.vala 2013-04-17 18:27:22 +0000
18@@ -63,6 +63,15 @@
19 debug ("Purged %u rows.", purged);
20 }
21 );
22+ acct_manager.account_created.connect ((manager, account_id) => {
23+ debug ("Account %u created from UOA, refreshing", account_id);
24+ try {
25+ dispatcher.Refresh ();
26+ } catch (IOError e) {
27+ warning ("Failed to refresh - %s", e.message);
28+ }
29+ }
30+ );
31
32 resources = Dee.ResourceManager.get_default ();
33 model = new Dee.SequenceModel ();

Subscribers

People subscribed via source and target branches

to all changes: