Merge lp:~ken-vandine/friends/account_plugin_depends into lp:friends

Proposed by Ken VanDine
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 192
Merged at revision: 190
Proposed branch: lp:~ken-vandine/friends/account_plugin_depends
Merge into: lp:friends
Diff against target: 69 lines (+27/-5)
2 files modified
debian/changelog (+7/-0)
debian/control (+20/-5)
To merge this branch: bzr merge lp:~ken-vandine/friends/account_plugin_depends
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+159165@code.launchpad.net

Commit message

make the service plugins depend on the appropriate account plugins

Description of the change

make the service plugins depend on the appropriate account plugins

To post a comment you must log in.
191. By Ken VanDine

removed extra line

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:191
http://jenkins.qa.ubuntu.com/job/friends-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/friends-raring-amd64-ci/35

Click here to trigger a rebuild:
http://s-jenkins:8080/job/friends-ci/35/rebuild

review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

 Package: friends-foursquare
is in main, and it deps on account-plugin-foursquare which is in universe. We should either downgrade friends-foursquare to universe or do a MIR for the latter.

pedantic comment: would be great for, as every packages we have in PS now, add the finale "," to the depends ;)

review: Needs Fixing
192. By Ken VanDine

added trailing commas

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Fixed the trailing commas, friends-foursquare should get demoted to universe

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-10 14:41:53 +0000
3+++ debian/changelog 2013-04-16 15:43:23 +0000
4@@ -1,3 +1,10 @@
5+friends (0.1.3daily13.04.10.1-0ubuntu2) UNRELEASED; urgency=low
6+
7+ * debian/control
8+ - make the service plugins depend on the appropriate account plugins
9+
10+ -- Ken VanDine <ken.vandine@canonical.com> Tue, 16 Apr 2013 10:19:21 -0400
11+
12 friends (0.1.3daily13.04.10.1-0ubuntu1) raring; urgency=low
13
14 [ Robert Bruce Park ]
15
16=== modified file 'debian/control'
17--- debian/control 2013-02-22 00:06:42 +0000
18+++ debian/control 2013-04-16 15:43:23 +0000
19@@ -76,30 +76,45 @@
20
21 Package: friends-facebook
22 Architecture: all
23-Depends: friends, ${misc:Depends}, ${python3:Depends}
24+Depends: friends,
25+ ${misc:Depends},
26+ ${python3:Depends},
27+ account-plugin-facebook,
28 Description: Social integration with the desktop - Facebook
29 Provides social networking integration with the desktop
30
31 Package: friends-twitter
32 Architecture: all
33-Depends: friends, ${misc:Depends}, ${python3:Depends}
34+Depends: friends,
35+ ${misc:Depends},
36+ ${python3:Depends},
37+ account-plugin-twitter,
38 Description: Social integration with the desktop - Twitter
39 Provides social networking integration with the desktop
40
41 Package: friends-identica
42 Architecture: all
43-Depends: friends, ${misc:Depends}, ${python3:Depends}
44+Depends: friends,
45+ ${misc:Depends},
46+ ${python3:Depends},
47+ account-plugin-identica,
48 Description: Social integration with the desktop - Identi.ca
49 Provides social networking integration with the desktop
50
51 Package: friends-foursquare
52 Architecture: all
53-Depends: friends, ${misc:Depends}, ${python3:Depends}
54+Depends: friends,
55+ ${misc:Depends},
56+ ${python3:Depends},
57+ account-plugin-foursquare,
58 Description: Social integration with the desktop - Foursquare
59 Provides social networking integration with the desktop
60
61 Package: friends-flickr
62 Architecture: all
63-Depends: friends, ${misc:Depends}, ${python3:Depends}
64+Depends: friends,
65+ ${misc:Depends},
66+ ${python3:Depends},
67+ account-plugin-flickr,
68 Description: Social integration with the desktop - Flickr
69 Provides social networking integration with the desktop

Subscribers

People subscribed via source and target branches

to all changes: