Merge lp:~ken-vandine/friends-app/fix_avatar into lp:friends-app

Proposed by Ken VanDine
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 79
Merged at revision: 76
Proposed branch: lp:~ken-vandine/friends-app/fix_avatar
Merge into: lp:friends-app
Diff against target: 60 lines (+17/-9)
3 files modified
debian/changelog (+13/-0)
debian/control (+3/-2)
qml/StatusUpdateTile.qml (+1/-7)
To merge this branch: bzr merge lp:~ken-vandine/friends-app/fix_avatar
Reviewer Review Type Date Requested Status
Robert Bruce Park Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+170235@code.launchpad.net

Commit message

No longer attempt to append .100px to the avatar images

Description of the change

No longer attempt to append .100px to the avatar images

To post a comment you must log in.
79. By Ken VanDine

No longer attempt to append .100px to the avatar images (LP: #1177945)

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:79
http://jenkins.qa.ubuntu.com/job/friends-app-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/friends-app-saucy-amd64-ci/3

Click here to trigger a rebuild:
http://s-jenkins:8080/job/friends-app-ci/7/rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Nice and simple ;-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-06-18 14:29:30 +0000
3+++ debian/changelog 2013-06-19 04:45:32 +0000
4@@ -1,3 +1,16 @@
5+friends-app (0.91.1-0ubuntu1) UNRELEASED; urgency=low
6+
7+ * No longer attempt to append .100px to the avatar images (LP: #1177945)
8+
9+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 19 Jun 2013 00:08:47 -0400
10+
11+friends-app (0.91.0-0ubuntu2) saucy; urgency=low
12+
13+ * debian/control
14+ - depend on qtdeclarative5-hud1.0
15+
16+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 19 Jun 2013 00:08:47 -0400
17+
18 friends-app (0.91.0-0ubuntu1) saucy; urgency=low
19
20 [ Stuart Langridge ]
21
22=== modified file 'debian/control'
23--- debian/control 2013-04-05 16:39:00 +0000
24+++ debian/control 2013-06-19 04:45:32 +0000
25@@ -15,9 +15,10 @@
26 Architecture: amd64 i386 armhf
27 Depends: ${shlibs:Depends},
28 ${misc:Depends},
29+ qtdeclarative5-accounts-plugin,
30+ qtdeclarative5-friends-plugin (>= 0.1.0bzr13.04.02),
31+ qtdeclarative5-hud1.0,
32 qtdeclarative5-ubuntu-ui-toolkit-plugin,
33- qtdeclarative5-friends-plugin (>= 0.1.0bzr13.04.02),
34- qtdeclarative5-accounts-plugin,
35 Replaces: gwibber-service, gwibber (<< 3.7.0bzr13.04.05-0ubuntu1)
36 Conflicts: gwibber-service, gwibber (<< 3.7.0bzr13.04.05-0ubuntu1)
37 Provides: gwibber
38
39=== modified file 'qml/StatusUpdateTile.qml'
40--- qml/StatusUpdateTile.qml 2013-05-10 15:37:45 +0000
41+++ qml/StatusUpdateTile.qml 2013-06-19 04:45:32 +0000
42@@ -110,17 +110,11 @@
43 topMargin: units.gu(1)
44 }
45 image: Image {
46- source: Qt.resolvedUrl(avatar+".100px")
47+ source: Qt.resolvedUrl(avatar)
48 asynchronous: true
49 smooth: true
50 fillMode: Image.PreserveAspectCrop
51 sourceSize.width: units.dp(48)
52- onStatusChanged: {
53- if (status == Image.Error) {
54- console.log ("onStatusChanged Error: "+source);
55- source = Qt.resolvedUrl(avatar);
56- }
57- }
58 }
59
60 MouseArea {

Subscribers

People subscribed via source and target branches

to all changes: