Merge lp:~ken-vandine/evolution-indicator/evo_3.4 into lp:evolution-indicator

Proposed by Ken VanDine
Status: Merged
Approved by: Ted Gould
Approved revision: 86
Merged at revision: 86
Proposed branch: lp:~ken-vandine/evolution-indicator/evo_3.4
Merge into: lp:evolution-indicator
Diff against target: 138 lines (+21/-25)
3 files modified
configure.ac (+4/-1)
po/Makefile.in.in (+9/-4)
src/evolution-indicator.c (+8/-20)
To merge this branch: bzr merge lp:~ken-vandine/evolution-indicator/evo_3.4
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+107477@code.launchpad.net

Description of the change

Ported to evolution 3.4

NOTE: It really needs to be ported to gsettings as well, but at least it builds again

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

The po/Makefile.in.in changes look odd, but they're apparently taken from intltool.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2011-09-09 08:45:39 +0000
3+++ configure.ac 2012-05-25 21:08:18 +0000
4@@ -70,7 +70,7 @@
5 AC_SUBST(GCC_FLAGS)
6
7 PKG_CHECK_MODULES(DEPS,
8- indicate-0.6 >= 0.5.90
9+ indicate-0.7 >= 0.6.90
10 $EVOLUTION_PLUGIN
11 dbus-1
12 dbus-glib-1
13@@ -78,6 +78,9 @@
14 libcanberra
15 $GTKHTML_EDITOR
16 unity
17+ libebackend-1.2
18+ libsoup-2.4
19+ gconf-2.0
20 )
21 AC_SUBST(DEPS_CFLAGS)
22 AC_SUBST(DEPS_LIBS)
23
24=== modified file 'po/Makefile.in.in'
25--- po/Makefile.in.in 2009-11-19 18:51:08 +0000
26+++ po/Makefile.in.in 2012-05-25 21:08:18 +0000
27@@ -49,8 +49,8 @@
28 XGETTEXT = @XGETTEXT@
29 INTLTOOL_UPDATE = @INTLTOOL_UPDATE@
30 INTLTOOL_EXTRACT = @INTLTOOL_EXTRACT@
31-MSGMERGE = INTLTOOL_EXTRACT=$(INTLTOOL_EXTRACT) srcdir=$(srcdir) $(INTLTOOL_UPDATE) --gettext-package $(GETTEXT_PACKAGE) --dist
32-GENPOT = INTLTOOL_EXTRACT=$(INTLTOOL_EXTRACT) srcdir=$(srcdir) $(INTLTOOL_UPDATE) --gettext-package $(GETTEXT_PACKAGE) --pot
33+MSGMERGE = INTLTOOL_EXTRACT="$(INTLTOOL_EXTRACT)" XGETTEXT="$(XGETTEXT)" srcdir=$(srcdir) $(INTLTOOL_UPDATE) --gettext-package $(GETTEXT_PACKAGE) --dist
34+GENPOT = INTLTOOL_EXTRACT="$(INTLTOOL_EXTRACT)" XGETTEXT="$(XGETTEXT)" srcdir=$(srcdir) $(INTLTOOL_UPDATE) --gettext-package $(GETTEXT_PACKAGE) --pot
35
36 ALL_LINGUAS = @ALL_LINGUAS@
37
38@@ -73,15 +73,20 @@
39 .SUFFIXES:
40 .SUFFIXES: .po .pox .gmo .mo .msg .cat
41
42+AM_DEFAULT_VERBOSITY = @AM_DEFAULT_VERBOSITY@
43+INTLTOOL_V_MSGFMT = $(INTLTOOL__v_MSGFMT_$(V))
44+INTLTOOL__v_MSGFMT_= $(INTLTOOL__v_MSGFMT_$(AM_DEFAULT_VERBOSITY))
45+INTLTOOL__v_MSGFMT_0 = @echo " MSGFMT" $@;
46+
47 .po.pox:
48 $(MAKE) $(GETTEXT_PACKAGE).pot
49 $(MSGMERGE) $< $(GETTEXT_PACKAGE).pot -o $*.pox
50
51 .po.mo:
52- $(MSGFMT) -o $@ $<
53+ $(INTLTOOL_V_MSGFMT)$(MSGFMT) -o $@ $<
54
55 .po.gmo:
56- file=`echo $* | sed 's,.*/,,'`.gmo \
57+ $(INTLTOOL_V_MSGFMT)file=`echo $* | sed 's,.*/,,'`.gmo \
58 && rm -f $$file && $(GMSGFMT) -o $$file $<
59
60 .po.cat:
61
62=== modified file 'src/evolution-indicator.c'
63--- src/evolution-indicator.c 2011-06-28 22:10:50 +0000
64+++ src/evolution-indicator.c 2012-05-25 21:08:18 +0000
65@@ -42,6 +42,8 @@
66 #include <shell/es-event.h>
67 #include <shell/e-shell-view.h>
68
69+#include <camel/camel.h>
70+
71 #include <libindicate/server.h>
72 #include <libindicate/indicator.h>
73 #include <libindicate/indicator-messages.h>
74@@ -142,7 +144,6 @@
75 static GdkWindow *root = NULL;
76 gboolean res = FALSE;
77 Window xwindow;
78- GList *list;
79 EShell *evo_shell;
80 EShellWindow *shell_window;
81
82@@ -180,16 +181,9 @@
83 }
84
85 evo_shell = e_shell_get_default ();
86- list = e_shell_get_watched_windows (evo_shell);
87-
88- /* Find the first EShellWindow in the list. */
89- while (list != NULL && !E_IS_SHELL_WINDOW (list->data))
90- list = g_list_next (list);
91-
92- g_return_if_fail (list != NULL);
93
94 /* Get the shell window. */
95- shell_window = E_SHELL_WINDOW (list->data);
96+ shell_window = E_SHELL_WINDOW (e_shell_get_active_window (evo_shell));
97
98 if (GTK_IS_WINDOW (shell_window))
99 {
100@@ -228,10 +222,13 @@
101 org_gnome_mail_new_notify (EPlugin *ep, EMEventTargetFolder *t)
102 {
103 gchar *url;
104+ CamelURL *service_url;
105
106 g_return_if_fail (t != NULL);
107
108- url = camel_service_get_url (CAMEL_SERVICE (t->store));
109+ service_url = camel_service_new_camel_url (CAMEL_SERVICE (t->store));
110+ url = camel_url_to_string (service_url, 0);
111+ camel_url_free (service_url);
112
113 if (!t->new)
114 return;
115@@ -1008,22 +1005,13 @@
116 if (shell)
117 {
118 GSList *i;
119- GList *list;
120- GtkWindow *mail_window = NULL;
121 EShellWindow *shell_window;
122 EShellView *shell_view;
123 GtkAction *action;
124
125- list = e_shell_get_watched_windows (shell);
126-
127- /* Find the first EShellWindow in the list. */
128- while (list != NULL && !E_IS_SHELL_WINDOW (list->data))
129- list = g_list_next (list);
130-
131- g_return_if_fail (list != NULL);
132
133 /* Present the shell window. */
134- shell_window = E_SHELL_WINDOW (list->data);
135+ shell_window = E_SHELL_WINDOW (e_shell_get_active_window (shell));
136 if (!evolution_is_focused ())
137 {
138 gtk_window_present_with_time (GTK_WINDOW (shell_window), timestamp);

Subscribers

People subscribed via source and target branches