Merge lp:~ken-vandine/libdbusmenu/warn-all into lp:libdbusmenu/0.5

Proposed by Ken VanDine
Status: Merged
Merged at revision: 189
Proposed branch: lp:~ken-vandine/libdbusmenu/warn-all
Merge into: lp:libdbusmenu/0.5
Diff against target: 37 lines (+4/-0)
2 files modified
libdbusmenu-glib/Makefile.am (+2/-0)
libdbusmenu-gtk/Makefile.am (+2/-0)
To merge this branch: bzr merge lp:~ken-vandine/libdbusmenu/warn-all
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+46867@code.launchpad.net

Description of the change

added --warn-all to scanner flags so the build log will warn us about missing annotations

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libdbusmenu-glib/Makefile.am'
2--- libdbusmenu-glib/Makefile.am 2011-01-18 15:02:47 +0000
3+++ libdbusmenu-glib/Makefile.am 2011-01-20 03:54:26 +0000
4@@ -119,12 +119,14 @@
5
6 if INTROSPECTION_TEN
7 INTROSPECTION_SCANNER_ARGS = --add-include-path=$(srcdir) \
8+ --warn-all \
9 --add-include-path=$(srcdir) \
10 $(addprefix --c-include=libdbusmenu-glib/, $(introspection_sources)) \
11 --symbol-prefix=dbusmenu \
12 --identifier-prefix=Dbusmenu
13 else
14 INTROSPECTION_SCANNER_ARGS = --add-include-path=$(srcdir) \
15+ --warn-all \
16 --add-include-path=$(srcdir) \
17 $(addprefix --c-include=libdbusmenu-glib/, $(introspection_sources))
18 endif
19
20=== modified file 'libdbusmenu-gtk/Makefile.am'
21--- libdbusmenu-gtk/Makefile.am 2011-01-18 15:02:47 +0000
22+++ libdbusmenu-gtk/Makefile.am 2011-01-20 03:54:26 +0000
23@@ -69,12 +69,14 @@
24
25 if INTROSPECTION_TEN
26 INTROSPECTION_SCANNER_ARGS = --add-include-path=$(srcdir) \
27+ --warn-all \
28 --add-include-path=$(top_builddir)/libdbusmenu-glib \
29 $(addprefix --c-include=libdbusmenu-gtk/, $(introspection_sources)) \
30 --symbol-prefix=dbusmenu \
31 --identifier-prefix=DbusmenuGtk
32 else
33 INTROSPECTION_SCANNER_ARGS = --add-include-path=$(srcdir) \
34+ --warn-all \
35 --add-include-path=$(top_builddir)/libdbusmenu-glib \
36 $(addprefix --c-include=libdbusmenu-gtk/, $(introspection_sources))
37 endif

Subscribers

People subscribed via source and target branches