Merge lp:~ken-vandine/content-hub/serialized_content_transfers into lp:content-hub
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Michael Sheldon on 2015-04-22 | ||||
| Approved revision: | 205 | ||||
| Merged at revision: | 200 | ||||
| Proposed branch: | lp:~ken-vandine/content-hub/serialized_content_transfers | ||||
| Merge into: | lp:content-hub | ||||
| Diff against target: |
565 lines (+189/-28) 21 files modified
examples/exporter/exampleexporter.cpp (+5/-1) examples/importer/exampleimporter.cpp (+6/-3) examples/importer/importer.cpp (+1/-0) import/Ubuntu/Content/contentitem.cpp (+20/-0) import/Ubuntu/Content/contentitem.h (+5/-0) import/Ubuntu/Content/contenttype.cpp (+6/-0) import/Ubuntu/Content/contenttype.h (+2/-1) include/com/ubuntu/content/item.h (+11/-1) include/com/ubuntu/content/type.h (+1/-0) src/com/ubuntu/content/detail/transfer.cpp (+12/-9) src/com/ubuntu/content/item.cpp (+56/-6) src/com/ubuntu/content/service/com.ubuntu.content.hub.gschema.xml (+12/-0) src/com/ubuntu/content/service/hook.cpp (+1/-1) src/com/ubuntu/content/type.cpp (+6/-0) tests/acceptance-tests/app_hub_communication_transfer.cpp (+4/-2) tests/peers/exporter/autoexporter.cpp (+6/-0) tests/peers/importer/autoimporter.cpp (+6/-0) tests/peers/importer/content-hub-test-importer.json (+2/-1) tests/peers/sharer/autosharer.cpp (+6/-0) tests/peers/sharer/content-hub-test-sharer.json (+2/-1) tests/qml-tests/tst_ContentHub.qml (+19/-2) |
||||
| To merge this branch: | bzr merge lp:~ken-vandine/content-hub/serialized_content_transfers | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michael Sheldon (community) | 2015-04-13 | Approve on 2015-04-22 | |
| PS Jenkins bot | continuous-integration | Approve on 2015-04-21 | |
|
Review via email:
|
|||
Commit Message
Added ContentType.Text as a well known type
Added ContentItem.text property for serialized content
Description of the Change
Added ContentType.Text as a well known type
Added ContentItem.text property for serialized content
This can be tested the following 2 clicks installed:
* http://
* http://
1. Launch the hub-text-exporter app, enter some text and click "Share with..."
2. Select "Telegram" from the peer picker
3. Choose a chat to insert the text in
Expected results: You should see the text entered posted to the chat.
- 201. By Ken VanDine on 2015-04-14
-
Added more debug output to the test peers
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:201
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 202. By Ken VanDine on 2015-04-21
-
Don't force streamType to x-url when the url is set, this lets a link shared include text as well.
- 203. By Ken VanDine on 2015-04-21
-
ensure the ContentItem.text property gets set when copying/linking files
- 204. By Ken VanDine on 2015-04-21
-
Don't create a new Item to for the copied file, just change the url.
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:204
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Ken VanDine (ken-vandine) wrote : | # |
Are there any related MPs required for this MP to build/function as expected? Please list.
* No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
* Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
* Yes
Did you successfully run all tests found in your component's Test Plan (https:/
* Yes
If you changed the UI, was the change specified/approved by design?
* No change
If you changed UI labels, did you update the pot file?
* No change
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
* No change
- 205. By Ken VanDine on 2015-04-21
-
merged trunk
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:205
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
| Michael Sheldon (michael-sheldon) wrote : | # |
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
* Yes
Did CI run pass? If not, please explain why.
* Yes
Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
* Yes

PASSED: Continuous integration, rev:200 jenkins. qa.ubuntu. com/job/ content- hub-ci/ 245/ jenkins. qa.ubuntu. com/job/ content- hub-vivid- amd64-ci/ 41 jenkins. qa.ubuntu. com/job/ content- hub-vivid- armhf-ci/ 41 jenkins. qa.ubuntu. com/job/ content- hub-vivid- armhf-ci/ 41/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ content- hub-vivid- i386-ci/ 41
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/content- hub-ci/ 245/rebuild
http://