Merge lp:~ken-vandine/content-hub/qdoc_fixmes into lp:~content-hub-team/content-hub/trunk

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 65
Merged at revision: 65
Proposed branch: lp:~ken-vandine/content-hub/qdoc_fixmes
Merge into: lp:~content-hub-team/content-hub/trunk
Diff against target: 79 lines (+6/-14)
4 files modified
import/Ubuntu/Content/contenthub.cpp (+0/-4)
import/Ubuntu/Content/contenthub.h (+0/-4)
import/Ubuntu/Content/contentitem.cpp (+3/-4)
import/Ubuntu/Content/contentpeer.cpp (+3/-2)
To merge this branch: bzr merge lp:~ken-vandine/content-hub/qdoc_fixmes
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sebastien Bacher (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+194412@code.launchpad.net

Commit message

Filled in the missing docstrings for the QML bindings

Description of the change

Filled in the missing docstrings for the QML bindings

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'import/Ubuntu/Content/contenthub.cpp'
2--- import/Ubuntu/Content/contenthub.cpp 2013-10-23 12:30:55 +0000
3+++ import/Ubuntu/Content/contenthub.cpp 2013-11-07 20:21:25 +0000
4@@ -221,8 +221,6 @@
5
6 /*!
7 * \qmlmethod ContentHub::restoreImports()
8- *
9- * FIXME add documentation
10 * \internal
11 */
12 void ContentHub::restoreImports()
13@@ -232,8 +230,6 @@
14
15 /*!
16 * \qmlproperty list<ContentTransfer> ContentHub::finishedImports
17- *
18- * FIXME add documentation
19 * \internal
20 */
21 QQmlListProperty<ContentTransfer> ContentHub::finishedImports()
22
23=== modified file 'import/Ubuntu/Content/contenthub.h'
24--- import/Ubuntu/Content/contenthub.h 2013-10-22 20:54:47 +0000
25+++ import/Ubuntu/Content/contenthub.h 2013-11-07 20:21:25 +0000
26@@ -39,10 +39,6 @@
27 }
28 }
29
30-/*!
31- * \class ContentHub
32- * \brief FIXME documentaion
33- */
34 class ContentHub : public QObject
35 {
36 Q_OBJECT
37
38=== modified file 'import/Ubuntu/Content/contentitem.cpp'
39--- import/Ubuntu/Content/contentitem.cpp 2013-10-21 16:36:02 +0000
40+++ import/Ubuntu/Content/contentitem.cpp 2013-11-07 20:21:25 +0000
41@@ -22,9 +22,9 @@
42 * \qmltype ContentItem
43 * \instantiates ContentItem
44 * \inqmlmodule Ubuntu.Content 0.1
45- * \brief FIXME add documentation
46+ * \brief Content that can be imported or exported from a ContentPeer
47 *
48- * FIXME add documentation
49+ * A ContentItem is an item that can be imported or exported from a ContentPeer
50 *
51 * See documentation for ContentHub
52 */
53@@ -39,8 +39,7 @@
54
55 /*!
56 * \qmlproperty string ContentItem::name
57- *
58- * FIXME add documentation
59+ * \internal
60 */
61 const QString &ContentItem::name() const
62 {
63
64=== modified file 'import/Ubuntu/Content/contentpeer.cpp'
65--- import/Ubuntu/Content/contentpeer.cpp 2013-10-23 12:09:07 +0000
66+++ import/Ubuntu/Content/contentpeer.cpp 2013-11-07 20:21:25 +0000
67@@ -24,9 +24,10 @@
68 * \qmltype ContentPeer
69 * \instantiates ContentPeer
70 * \inqmlmodule Ubuntu.Content 0.1
71- * \brief FIXME add documentation
72+ * \brief An application that can export or import a ContentType
73 *
74- * FIXME add documentation
75+ * A ContentPeer is an application that is registered in the ContentHub as
76+ * a source or destination of a ContentType
77 *
78 * See documentation for ContentHub
79 */

Subscribers

People subscribed via source and target branches