Merge lp:~ken-vandine/content-hub/picker_more_ap_friendly into lp:content-hub

Proposed by Ken VanDine
Status: Merged
Approved by: Michael Sheldon
Approved revision: 112
Merged at revision: 111
Proposed branch: lp:~ken-vandine/content-hub/picker_more_ap_friendly
Merge into: lp:content-hub
Diff against target: 13 lines (+2/-1)
1 file modified
import/Ubuntu/Content/ContentPeerPicker.qml (+2/-1)
To merge this branch: bzr merge lp:~ken-vandine/content-hub/picker_more_ap_friendly
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+222244@code.launchpad.net

Commit message

Added objectName to the cancel button in the ContentPeerPicker, it'll be useful for autopilot tests.

Description of the change

Added objectName to the cancel button in the ContentPeerPicker, it'll be useful for autopilot tests.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed the packaging (debian), did you subscribe a core-dev to this MP?

 * No change

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'import/Ubuntu/Content/ContentPeerPicker.qml'
2--- import/Ubuntu/Content/ContentPeerPicker.qml 2014-05-27 11:51:21 +0000
3+++ import/Ubuntu/Content/ContentPeerPicker.qml 2014-06-05 18:10:00 +0000
4@@ -288,7 +288,8 @@
5
6 Button {
7 id: cancelButton
8- text: "Cancel"
9+ objectName: "contentPeerPickerCancelButton"
10+ text: i18n.tr("Cancel")
11 anchors {
12 left: parent.left
13 bottom: parent.bottom

Subscribers

People subscribed via source and target branches