Merge lp:~ken-vandine/content-hub/missed_qdebug into lp:content-hub

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 81
Merged at revision: 86
Proposed branch: lp:~ken-vandine/content-hub/missed_qdebug
Merge into: lp:content-hub
Diff against target: 21 lines (+2/-2)
1 file modified
src/com/ubuntu/content/detail/service.cpp (+2/-2)
To merge this branch: bzr merge lp:~ken-vandine/content-hub/missed_qdebug
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+212847@code.launchpad.net

Commit message

Replace a couple missed qDebug lines for logging

Description of the change

Replace a couple missed qDebug lines for logging

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Are there any related MPs required for this MP to build/function as expected?
 * No
Is your branch in sync with latest trunk
 * Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
 * Yes
Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?
 * Yes
If you changed the UI, was the change specified/approved by design?
 * No UI changes
If you changed the packaging (debian), did you subscribe a core-dev to this MP?
 * No packaging changes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/com/ubuntu/content/detail/service.cpp'
2--- src/com/ubuntu/content/detail/service.cpp 2014-03-21 00:46:47 +0000
3+++ src/com/ubuntu/content/detail/service.cpp 2014-03-26 13:35:57 +0000
4@@ -311,7 +311,7 @@
5 }
6 if (t->destination() == transfer->destination())
7 {
8- qDebug() << Q_FUNC_INFO << "Destination has pending transfers:" << t->Id();
9+ TRACE() << Q_FUNC_INFO << "Destination has pending transfers:" << t->Id();
10 if (should_cancel(t->State()))
11 shouldStop = false;
12 }
13@@ -388,7 +388,7 @@
14 }
15 if (t->destination() == transfer->destination())
16 {
17- qDebug() << Q_FUNC_INFO << "Destination has pending transfers:" << t->Id();
18+ TRACE() << Q_FUNC_INFO << "Destination has pending transfers:" << t->Id();
19 if (should_cancel(t->State()))
20 shouldStop = false;
21 }

Subscribers

People subscribed via source and target branches