Merge lp:~ken-vandine/content-hub/lp1394211 into lp:content-hub

[Ken VanDine]

Fixed conflict with nih-dbus and our own i18n wrapper

Fixed conflict with nih-dbus and our own i18n wrapper

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:168
http://jenkins.qa.ubuntu.com/job/content-hub-ci/209/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/content-hub-vivid-i386-ci/5

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/content-hub-ci/209/rebuild

review: Approve (continuous-integration)

[Ken VanDine (ken-vandine)]

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * Yes

If you changed the UI, was the change specified/approved by design?

 * No change

If you changed UI labels, did you update the pot file?

 * No change

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * No change

[Michael Sheldon (michael-sheldon)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?

 * Yes

Did CI run pass? If not, please explain why.

 * Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?

 * Yes

review: Approve

=== modified file 'po/CMakeLists.txt'
--- po/CMakeLists.txt	2014-08-14 11:49:28 +0000
+++ po/CMakeLists.txt	2014-11-19 18:39:36 +0000
@@ -20,7 +20,7 @@
                           -D ${CMAKE_SOURCE_DIR}
                           --from-code=UTF-8
                           --c++ --qt --add-comments=TRANSLATORS
-                          --keyword=_
+                          --keyword=__
                           -j
                           --package-name=content-hub
                           --copyright-holder='Canonical Ltd.'

=== modified file 'src/com/ubuntu/content/detail/i18n.cpp'
--- src/com/ubuntu/content/detail/i18n.cpp	2014-05-01 17:03:40 +0000
+++ src/com/ubuntu/content/detail/i18n.cpp	2014-11-19 18:39:36 +0000
@@ -36,7 +36,7 @@
     textdomain(domain);
 }
 
-QString _(const char *text, const char *domain)
+QString __(const char *text, const char *domain)
 {
     return QString::fromUtf8(dgettext(domain, text));
 }

=== modified file 'src/com/ubuntu/content/detail/i18n.h'
--- src/com/ubuntu/content/detail/i18n.h	2014-05-01 17:03:40 +0000
+++ src/com/ubuntu/content/detail/i18n.h	2014-11-19 18:39:36 +0000
@@ -31,7 +31,7 @@
 {
 
 void initTr(const char *domain, const char *localeDir);
-QString _(const char *text, const char *domain = 0);
+QString __(const char *text, const char *domain = 0);
 
 }
 }

=== modified file 'src/com/ubuntu/content/detail/service.cpp'
--- src/com/ubuntu/content/detail/service.cpp	2014-08-04 17:56:09 +0000
+++ src/com/ubuntu/content/detail/service.cpp	2014-11-19 18:39:36 +0000
@@ -207,13 +207,13 @@
     t->Charge(QVariantList());
 }
 
-void download_notify (cucd::Transfer* t)
+void cucd::Service::download_notify (cucd::Transfer* t)
 {
     TRACE() << Q_FUNC_INFO;
     notify_init(t->source().toStdString().c_str());
     NotifyNotification* notification;
 
-    notification = notify_notification_new (_("Download Complete"),
+    notification = notify_notification_new (__("Download Complete").toStdString().c_str(),
                                             "",
                                             "save");
 
@@ -231,14 +231,14 @@
 
     notify_notification_add_action (notification,
                                     "action_accept",
-                                    _("Open"),
+                                    __("Open").toStdString().c_str(),
                                     action_accept,
                                     t,
                                     NULL);
 
     notify_notification_add_action (notification,
                                     "action_dismiss",
-                                    _("Dismiss"),
+                                    __("Dismiss").toStdString().c_str(),
                                     action_dismiss,
                                     t,
                                     NULL);
@@ -256,7 +256,7 @@
     notify_init("Download Manager");
     NotifyNotification* notification;
 
-    notification = notify_notification_new (_("Download Failed"),
+    notification = notify_notification_new (__("Download Failed").toStdString().c_str(),
                                             errorMessage.toStdString().c_str(),
                                             "save");
 

=== modified file 'src/com/ubuntu/content/detail/service.h'
--- src/com/ubuntu/content/detail/service.h	2014-08-04 17:56:09 +0000
+++ src/com/ubuntu/content/detail/service.h	2014-11-19 18:39:36 +0000
@@ -28,6 +28,7 @@
 
 #include <com/ubuntu/applicationmanager/application_manager.h>
 #include "handler.h"
+#include "transfer.h"
 
 namespace com
 {
@@ -78,6 +79,7 @@
     void handle_exports(int);
     void handler_unregistered(const QString&);
     QDBusObjectPath CreateTransfer(const QString&, const QString&, int, const QString&);
+    void download_notify (com::ubuntu::content::detail::Transfer*);
 
 };
 }