Merge lp:~ken-vandine/content-hub/desktop_file_less into lp:content-hub

Proposed by Ken VanDine
Status: Needs review
Proposed branch: lp:~ken-vandine/content-hub/desktop_file_less
Merge into: lp:content-hub
Prerequisite: lp:~ken-vandine/content-hub/ual_cpp_multi_instance
Diff against target: 62 lines (+9/-19)
4 files modified
debian/content-hub.install (+0/-1)
src/helper/exec-tool.c (+9/-0)
tools/peer-picker/CMakeLists.txt (+0/-5)
tools/peer-picker/content-hub-peer-picker.desktop (+0/-13)
To merge this branch: bzr merge lp:~ken-vandine/content-hub/desktop_file_less
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+317554@code.launchpad.net

Commit message

Updated the exec-tool helper to fall back to building the exec line manually when no desktop files are installed. Dropped desktop file from content-hub-peer-picker

Description of the change

Updated the exec-tool helper to fall back to building the exec line manually when no desktop files are installed. Dropped desktop file from content-hub-peer-picker

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:320
https://jenkins.canonical.com/system-apps/job/lp-content-hub-ci/1/
Executed test runs:

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-content-hub-ci/1/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

320. By Ken VanDine

merged ual_cpp_multi_instance branch

319. By Ken VanDine

Updated the exec-tool helper to fall back to building the exec line manually when no desktop files are installed. Dropped desktop file from content-hub-peer-picker

318. By Ken VanDine

Updated the exec-tool helper to fall back to building the exec line manually if there is no desktop file installed

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/content-hub.install'
2--- debian/content-hub.install 2016-12-07 16:36:53 +0000
3+++ debian/content-hub.install 2017-02-16 21:05:41 +0000
4@@ -9,7 +9,6 @@
5 usr/share/glib-2.0/schemas
6 usr/share/locale/*/LC_MESSAGES/content-hub.mo
7 usr/share/applications/content-hub-send.desktop
8-usr/share/applications/content-hub-peer-picker.desktop
9 usr/share/url-dispatcher/urls/content-hub-send.url-dispatcher
10 usr/share/content-hub/icons
11 debian/apparmor/content-hub-peer-picker etc/apparmor.d
12
13=== modified file 'src/helper/exec-tool.c'
14--- src/helper/exec-tool.c 2016-11-09 17:55:06 +0000
15+++ src/helper/exec-tool.c 2017-02-16 21:05:41 +0000
16@@ -144,6 +144,15 @@
17 }
18
19 if (exec == NULL) {
20+ const gchar * snapdir = g_getenv("SNAP");
21+ if (snapdir != NULL) {
22+ exec = g_build_filename(snapdir, "bin", appid, NULL);
23+ } else {
24+ exec = g_build_filename("/", "usr", "bin", appid, NULL);
25+ }
26+ }
27+
28+ if (exec == NULL) {
29 const gchar * props[3] = {
30 "AppID",
31 appid,
32
33=== modified file 'tools/peer-picker/CMakeLists.txt'
34--- tools/peer-picker/CMakeLists.txt 2016-11-17 19:38:37 +0000
35+++ tools/peer-picker/CMakeLists.txt 2017-02-16 21:05:41 +0000
36@@ -39,8 +39,3 @@
37 TARGETS content-hub-peer-picker
38 RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
39 )
40-
41-install(
42- FILES content-hub-peer-picker.desktop
43- DESTINATION ${CMAKE_INSTALL_DATADIR}/applications
44-)
45
46=== removed file 'tools/peer-picker/content-hub-peer-picker.desktop'
47--- tools/peer-picker/content-hub-peer-picker.desktop 2016-11-16 18:25:30 +0000
48+++ tools/peer-picker/content-hub-peer-picker.desktop 1970-01-01 00:00:00 +0000
49@@ -1,13 +0,0 @@
50-[Desktop Entry]
51-Version=1.0
52-Name=Content Hub Peer Picker
53-Comment=Content Hub Peer Picker
54-Exec=content-hub-peer-picker %U
55-Icon=
56-Terminal=false
57-Type=Application
58-OnlyShowIn=Old
59-X-Ubuntu-Touch=true
60-X-Ubuntu-Single-Instance=false
61-X-Ubuntu-Splash-Show-Header=true
62-X-Ubuntu-Splash-Title=Choose from

Subscribers

People subscribed via source and target branches