Merge lp:~ken-vandine/content-hub/content-hub_dh-translations into lp:content-hub

Proposed by Ken VanDine
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 136
Merged at revision: 136
Proposed branch: lp:~ken-vandine/content-hub/content-hub_dh-translations
Merge into: lp:content-hub
Diff against target: 24 lines (+2/-1)
2 files modified
debian/control (+1/-0)
debian/rules (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/content-hub/content-hub_dh-translations
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+234597@code.launchpad.net

Commit message

Build with dh_translations (LP: #1359166)

Description of the change

Build with dh_translations (LP: #1359166)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Are there any related MPs required for this MP to build/function as expected? Please list.

 * No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

 * Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

 * No need, packaging only change to generate the content-hub.pot file needed for ubuntu translations

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/content-hub) on device or emulator?

 * No need, packaging only change to generate the content-hub.pot file needed for ubuntu translations

If you changed the UI, was the change specified/approved by design?

 * NA

If you changed UI labels, did you update the pot file?

 * NA

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

 * Yes

Revision history for this message
Sebastien Bacher (seb128) wrote :

nice

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-07-23 19:58:53 +0000
3+++ debian/control 2014-09-14 15:20:45 +0000
4@@ -5,6 +5,7 @@
5 click-dev,
6 dbus-test-runner,
7 debhelper (>= 9),
8+ dh-translations,
9 doxygen,
10 google-mock,
11 lcov,
12
13=== modified file 'debian/rules'
14--- debian/rules 2013-09-23 20:55:14 +0000
15+++ debian/rules 2014-09-14 15:20:45 +0000
16@@ -4,7 +4,7 @@
17 export DPKG_GENSYMBOLS_CHECK_LEVEL=4
18
19 %:
20- dh $@ --with click --fail-missing -- -B build
21+ dh $@ --with click,translations --fail-missing -- -B build
22
23 override_dh_auto_test:
24 dbus-test-runner -t make -p "-C" -p "build/tests/acceptance-tests" -p test

Subscribers

People subscribed via source and target branches