Merge lp:~ken-vandine/autopilot/depends_for_gsettings into lp:autopilot

Proposed by Ken VanDine on 2015-07-22
Status: Merged
Merged at revision: 566
Proposed branch: lp:~ken-vandine/autopilot/depends_for_gsettings
Merge into: lp:autopilot
Diff against target: 19 lines (+2/-0)
1 file modified
debian/control (+2/-0)
To merge this branch: bzr merge lp:~ken-vandine/autopilot/depends_for_gsettings
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2015-07-22
Iain Lane (community) Needs Fixing on 2015-07-22
Max Brustkern (community) 2015-07-22 Approve on 2015-07-22
Review via email: mp+265580@code.launchpad.net

Commit message

added depends for libglib2.0-bin

Description of the change

added depends for libglib2.0-bin

This is needed to fix autopkgtests that are now failing because of the recent gsettings addition.

To post a comment you must log in.
Max Brustkern (nuclearbob) wrote :

This looks good to me. I'll see what we can do about getting a release.

review: Approve
567. By Ken VanDine on 2015-07-22

Depend on ubuntu-keyboard-data for the gsettings schema

Max Brustkern (nuclearbob) wrote :

Thanks, this should be good as well.

review: Approve
Iain Lane (laney) wrote :

Can we please instead make this opt in with a soft depends for those tests/projects that need it? I don't see why all users of autopilot should be forced to do things to work around problems with the Ubuntu keyboard that may not remotely concern them.

And please let's use the proper API for interacting with gsettings instead of an administration tool.

review: Needs Fixing
Christopher Lee (veebers) wrote :

> Can we please instead make this opt in with a soft depends for those
> tests/projects that need it? I don't see why all users of autopilot should be
> forced to do things to work around problems with the Ubuntu keyboard that may
> not remotely concern them.
>
> And please let's use the proper API for interacting with gsettings instead of
> an administration tool.

These concerns should be address with this branch: https://code.launchpad.net/~canonical-platform-qa/autopilot/depends_for_gsettings/+merge/265621

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2015-07-16 03:24:34 +0000
3+++ debian/control 2015-07-22 17:52:33 +0000
4@@ -43,6 +43,7 @@
5 Package: python3-autopilot
6 Architecture: all
7 Depends: gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
8+ libglib2.0-bin,
9 libjs-jquery,
10 libjs-underscore,
11 python3-dateutil,
12@@ -56,6 +57,7 @@
13 python3-subunit,
14 python3-testscenarios,
15 python3-testtools,
16+ ubuntu-keyboard-data,
17 udev,
18 ${misc:Depends},
19 ${python3:Depends},

Subscribers

People subscribed via source and target branches