Merge lp:~ken-vandine/autopilot/depends_for_gsettings into lp:autopilot

[Ken VanDine]

added depends for libglib2.0-bin

added depends for libglib2.0-bin

This is needed to fix autopkgtests that are now failing because of the recent gsettings addition.

[Max Brustkern (nuclearbob)]

This looks good to me. I'll see what we can do about getting a release.

review: Approve

[Ken VanDine (ken-vandine)]

Here's a log with more detail http://d-jenkins.ubuntu-ci:8080/view/Wily/view/AutoPkgTest/job/wily-adt-ubuntu-system-settings-online-accounts/68/ARCH=amd64,label=adt/console

[lp:~ken-vandine/autopilot/depends_for_gsettings]

567. By Ken VanDine on 2015-07-22

Depend on ubuntu-keyboard-data for the gsettings schema

[Max Brustkern (nuclearbob)]

Thanks, this should be good as well.

review: Approve

[Iain Lane (laney)]

Can we please instead make this opt in with a soft depends for those tests/projects that need it? I don't see why all users of autopilot should be forced to do things to work around problems with the Ubuntu keyboard that may not remotely concern them.

And please let's use the proper API for interacting with gsettings instead of an administration tool.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:567
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1123/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/52/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/53/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/3464
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2884
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3461
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/3461/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/22065

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1123/rebuild

review: Approve (continuous-integration)

[Christopher Lee (veebers)]

> Can we please instead make this opt in with a soft depends for those
> tests/projects that need it? I don't see why all users of autopilot should be
> forced to do things to work around problems with the Ubuntu keyboard that may
> not remotely concern them.
>
> And please let's use the proper API for interacting with gsettings instead of
> an administration tool.

These concerns should be address with this branch: https://code.launchpad.net/~canonical-platform-qa/autopilot/depends_for_gsettings/+merge/265621

=== modified file 'debian/control'
--- debian/control	2015-07-16 03:24:34 +0000
+++ debian/control	2015-07-22 17:52:33 +0000
@@ -43,6 +43,7 @@
 Package: python3-autopilot
 Architecture: all
 Depends: gir1.2-ubuntu-app-launch-2 | gir1.2-upstart-app-launch-2,
+         libglib2.0-bin,
          libjs-jquery,
          libjs-underscore,
          python3-dateutil,
@@ -56,6 +57,7 @@
          python3-subunit,
          python3-testscenarios,
          python3-testtools,
+         ubuntu-keyboard-data,
          udev,
          ${misc:Depends},
          ${python3:Depends},