Merge lp:~ken-vandine/account-plugins/credentialsId into lp:account-plugins

Proposed by Ken VanDine on 2013-02-08
Status: Merged
Approved by: David King on 2013-02-08
Approved revision: 90
Merged at revision: 90
Proposed branch: lp:~ken-vandine/account-plugins/credentialsId
Merge into: lp:account-plugins
Diff against target: 26 lines (+9/-1)
2 files modified
debian/changelog (+8/-0)
tools/account-console (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/account-plugins/credentialsId
Reviewer Review Type Date Requested Status
David King (community) 2013-02-08 Approve on 2013-02-08
PS Jenkins bot (community) continuous-integration Approve on 2013-02-08
Review via email: mp+147410@code.launchpad.net

Commit message

account-console: fixed a bug where it was failing to store the credentialsId because it was using the wrong type.

Description of the change

When using account-console to create an account, it was failing to store the CredentialsId because it was using the wrong type. This branch uses set_variant and a Variant.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-12-10 21:44:24 +0000
3+++ debian/changelog 2013-02-08 16:12:43 +0000
4@@ -1,3 +1,11 @@
5+account-plugins (0.10bzr13.02.08-0ubuntu1) UNRELEASED; urgency=low
6+
7+ [ Ken VanDine ]
8+ * account-console: fixed a bug where it was failing to store the
9+ credentialsId because it was using the wrong type.
10+
11+ -- Ken VanDine <ken.vandine@canonical.com> Fri, 08 Feb 2013 11:06:35 -0500
12+
13 account-plugins (0.10bzr12.12.10-0ubuntu1) raring; urgency=low
14
15 [ Ken VanDine ]
16
17=== modified file 'tools/account-console'
18--- tools/account-console 2012-11-23 10:43:30 +0000
19+++ tools/account-console 2013-02-08 16:12:43 +0000
20@@ -124,7 +124,7 @@
21
22
23 def on_credentials_stored(self, identity, id, error, account):
24- account.set_value(self.args.signon_id_field, int(id))
25+ account.set_variant(self.args.signon_id_field, GLib.Variant('u', id))
26 account.store(self.on_account_stored, None)
27
28

Subscribers

People subscribed via source and target branches

to all changes: