lp:~ken-pepple/nova/lp735641

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~hudson-openstack/nova/trunk at revision 841

Vish Ishaya (community): Approve on 2011-03-21

Rick Harris (community): Approve on 2011-03-17

Eric Day: Pending requested 2011-03-15

Diff: 72 lines (+27/-2)

2 files modified

nova/image/local.py (+15/-2)
nova/tests/api/openstack/test_images.py (+12/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #735641: Unclear error when images directory wasn't upgraded

Low

Fix Released

Link a bug report

Related blueprints

811. By Ken Pepple on 2011-03-17

better implementation of try..except..else

810. By Ken Pepple on 2011-03-17

merged trunk

809. By Ken Pepple on 2011-03-16

revised per code review

808. By Ken Pepple on 2011-03-15

wrap errors getting image ids from local image store

807. By Brian Lamar on 2011-03-15

Fixed lp732866 by catching relevant `exception.NotFound` exception. Tests did not uncover this vulnerability due to "incorrect" FakeAuthManager. I say "incorrect" because potentially different implementations (LDAP or Database driven) of AuthManager might return different errors from `get_user_from_access_key`.

Also, removed all references to 'bacon', 'ham', 'herp', and 'derp' and replaced them with hopefully more helpful terms.

Long story short it addresses the immediate issue while throughly ignoring the larger issue, which is correctly testing all implementations of Auth. I find this acceptable as currently the future of auth is in flux.

806. By Ken Pepple on 2011-03-15

just fixing a small typo in nova-manage vm live-migration

805. By Soren Hansen on 2011-03-15

Make Authors check account for tests being run with different os.getcwd() depending on how they're run. Add missing people to Authors.

804. By justinsb on 2011-03-15

Removed duplicated tests.

One was a straight copy-and-paste, one was different, but the masked test didn't pass.

803. By Josh Kearney on 2011-03-15

PEP8 0.5.0 cleanup.

802. By justinsb on 2011-03-15

Implements basic OpenStack API client, ready to support API tests