Merge lp:~kelwin-lee/scratch/fix-1212656 into lp:~elementary-apps/scratch/scratch

Proposed by Cuzzie Lee
Status: Merged
Approved by: Mario Guerriero
Approved revision: 1182
Merged at revision: 1182
Proposed branch: lp:~kelwin-lee/scratch/fix-1212656
Merge into: lp:~elementary-apps/scratch/scratch
Diff against target: 12 lines (+1/-1)
1 file modified
src/Services/Document.vala (+1/-1)
To merge this branch: bzr merge lp:~kelwin-lee/scratch/fix-1212656
Reviewer Review Type Date Requested Status
Mario Guerriero (community) Approve
Review via email: mp+180635@code.launchpad.net

Commit message

Description of the change

Changed the if condition under save_as() method. When a new file is edited and saved, the error no longer appears, and the file is saved successfully.

To post a comment you must log in.
Revision history for this message
Mario Guerriero (mefrio-g) wrote :

replace "get_text()" with "get_text ()" for code style reasons and it will be fine. Thank you for working on it!

review: Needs Fixing
lp:~kelwin-lee/scratch/fix-1212656 updated
1182. By Cuzzie Lee

Replaced get_text() with get_text ()

Revision history for this message
Cuzzie Lee (kelwin-lee) wrote :

> replace "get_text()" with "get_text ()" for code style reasons and it will be
> fine. Thank you for working on it!

Sorry about that, I forgot about the code style convention. Thanks for letting me know! I have committed the change. :)

Revision history for this message
Mario Guerriero (mefrio-g) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Services/Document.vala'
2--- src/Services/Document.vala 2013-08-01 12:48:22 +0000
3+++ src/Services/Document.vala 2013-08-17 04:33:14 +0000
4@@ -202,7 +202,7 @@
5 }
6
7 public bool save () {
8- if (!this.loaded && this.file != null)
9+ if (last_saved_content == get_text () && this.file != null)
10 return false;
11
12 // Create backup copy file if it does not still exist

Subscribers

People subscribed via source and target branches