Merge lp:~kelwin-lee/scratch/fix-1075241 into lp:~elementary-apps/scratch/scratch

Proposed by Cuzzie Lee
Status: Merged
Merged at revision: 1236
Proposed branch: lp:~kelwin-lee/scratch/fix-1075241
Merge into: lp:~elementary-apps/scratch/scratch
Diff against target: 21 lines (+2/-2)
1 file modified
src/Services/FileHandler.vala (+2/-2)
To merge this branch: bzr merge lp:~kelwin-lee/scratch/fix-1075241
Reviewer Review Type Date Requested Status
Mario Guerriero (community) Approve
Review via email: mp+180702@code.launchpad.net

Commit message

Description of the change

To post a comment you must log in.
Revision history for this message
Mario Guerriero (mefrio-g) :
review: Approve
lp:~kelwin-lee/scratch/fix-1075241 updated
1184. By Cuzzie Lee

Fixes bug #1190437

1185. By Cuzzie Lee

Fixes bug #1099130

Revision history for this message
Mario Guerriero (mefrio-g) wrote :

I just noticed that this branch make Scratch to load file all in a single line. It does not add any \n character at the source view so that the file is shown all in a line. I reverted, this merge request.

review: Needs Fixing
lp:~kelwin-lee/scratch/fix-1075241 updated
1186. By Cuzzie Lee

Merged with latest revision

1187. By Cuzzie Lee

Append newline for local revision

1188. By Cuzzie Lee

Fixes bug #1075241

Revision history for this message
Mario Guerriero (mefrio-g) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Services/FileHandler.vala'
2--- src/Services/FileHandler.vala 2013-08-19 20:54:19 +0000
3+++ src/Services/FileHandler.vala 2013-08-20 13:53:27 +0000
4@@ -38,7 +38,7 @@
5 text.append (line);
6 text.append_c ('\n');
7 }
8- return text.str;
9+ return text.erase(text.len - 1, 1);
10 } catch (Error e) {
11 warning ("Cannot read \"%s\": %s", file.get_basename (), e.message);
12 return null;
13@@ -57,7 +57,7 @@
14 text.append_c ('\n');
15 }
16 }
17- return text.str;
18+ return text.erase(text.len - 1, 1);
19 } catch (Error e) {
20 warning ("Cannot read \"%s\": %s", file.get_basename (), e.message);
21 return null;

Subscribers

People subscribed via source and target branches