Merge lp:~kelwin-lee/midori/fix-738479 into lp:midori

Proposed by Danielle Foré
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp:~kelwin-lee/midori/fix-738479
Merge into: lp:midori
Diff against target: 66 lines (+25/-3) (has conflicts)
1 file modified
midori/midori-browser.c (+25/-3)
Text conflict in midori/midori-browser.c
To merge this branch: bzr merge lp:~kelwin-lee/midori/fix-738479
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Midori Devs Pending
Review via email: mp+164676@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Clean lines 8, 9, 12 of the diff.

review: Needs Fixing

Unmerged revisions

4717. By Cuzzie Lee

Moved "Import Bookmarks" and "Export Bookmarks" to Bookmark menu

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-browser.c'
2--- midori/midori-browser.c 2013-05-19 09:33:02 +0000
3+++ midori/midori-browser.c 2013-05-20 06:52:26 +0000
4@@ -3095,6 +3095,11 @@
5 KatzeArray* folder,
6 MidoriBrowser* browser)
7 {
8+<<<<<<< TREE
9+=======
10+
11+ const gchar* folder_name;
12+>>>>>>> MERGE-SOURCE
13 KatzeArray* bookmarks;
14 const gchar* id = katze_item_get_meta_string (KATZE_ITEM (folder), "id");
15 gchar* condition;
16@@ -3116,6 +3121,21 @@
17 gtk_container_foreach (GTK_CONTAINER (menu),
18 (GtkCallback)(gtk_widget_destroy), NULL);
19
20+ /* "Import Bookmarks" and "Export Bookmarks" are moved here */
21+ gtk_menu_shell_append (menu, menuitem);
22+ gtk_widget_show (menuitem);
23+ menuitem = gtk_action_create_menu_item (
24+ _action_by_name (browser, "BookmarksImport"));
25+ gtk_menu_shell_append (menu, menuitem);
26+ gtk_widget_show (menuitem);
27+ menuitem = gtk_action_create_menu_item (
28+ _action_by_name (browser, "BookmarksExport"));
29+ gtk_menu_shell_append (menu, menuitem);
30+ gtk_widget_show (menuitem);
31+ menuitem = gtk_separator_menu_item_new ();
32+ gtk_menu_shell_append(menu, menuitem);
33+ gtk_widget_show (menuitem);
34+
35 if (katze_array_is_empty (bookmarks))
36 {
37 GtkWidget* menuitem = gtk_image_menu_item_new_with_label (_("Empty"));
38@@ -3127,6 +3147,7 @@
39
40 katze_array_action_generate_menu (KATZE_ARRAY_ACTION (action), bookmarks,
41 menu, GTK_WIDGET (browser));
42+
43 return TRUE;
44 }
45
46@@ -5708,8 +5729,6 @@
47 "<menuitem action='WindowClose'/>"
48 "<separator/>"
49 "<menuitem action='Print'/>"
50- "<menuitem action='BookmarksImport'/>"
51- "<menuitem action='BookmarksExport'/>"
52 "<separator/>"
53 "<menuitem action='Quit'/>"
54 "</menu>"
55@@ -5772,7 +5791,10 @@
56 "<menuitem action='Search'/>"
57 "<menuitem action='Trash'/>"
58 "</menu>"
59- "<menuitem action='Bookmarks'/>"
60+ "<menu action='Bookmarks'>"
61+ "<menuitem action='BookmarksImport'/>"
62+ "<menuitem action='BookmarksExport'/>"
63+ "</menu>"
64 "<menuitem action='Tools'/>"
65 "<menuitem action='Window'/>"
66 "<menu action='Help'>"

Subscribers

People subscribed via source and target branches

to all changes: