Merge lp:~kelvin.li/rnr-server/charm-supports into lp:rnr-server

Proposed by Kelvin Li
Status: Merged
Approved by: Michael Nelson
Approved revision: 360
Merged at revision: 303
Proposed branch: lp:~kelvin.li/rnr-server/charm-supports
Merge into: lp:rnr-server
Diff against target: 20 lines (+2/-1)
1 file modified
django_project/settings_base.py (+2/-1)
To merge this branch: bzr merge lp:~kelvin.li/rnr-server/charm-supports
Reviewer Review Type Date Requested Status
Wes Mason (community) Approve
Review via email: mp+262401@code.launchpad.net

Commit message

emty revision to trigger rollout

Description of the change

emty revision to trigger rollout

To post a comment you must log in.
360. By Kelvin Li

changed the rnr.log generate location to fit log sync pattern in metal

Revision history for this message
Kelvin Li (kelvin.li) wrote :

In mental staging environment, the rnr.log was generated in /srv/xxx/staging-logs/rnr.log,(changed from revno290[0])
and that doesn't fit the metal sync pattern rules, we lost the rnr.log from 20141105[1]

[0]http://bazaar.launchpad.net/~rnr-developers/rnr-server/trunk/revision/290
[1]@vanadium:/srv/admin.isd.canonical.com/isd-logs/waxapple/reviews/www-logs

Revision history for this message
Kelvin Li (kelvin.li) wrote :

Rollout trigger is because we added the BzrRevnoMiddleware[0], which relies on the versioninfo that introduced for juju, it didn't existed in the metal env, we added it into the puppet build step and need to land it.

[0]http://bazaar.launchpad.net/~rnr-developers/rnr-server/trunk/view/head:/src/core/wsgi.py#L43

Revision history for this message
Wes Mason (wesmason) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'django_project/settings_base.py'
2--- django_project/settings_base.py 2015-06-03 10:06:58 +0000
3+++ django_project/settings_base.py 2015-06-19 07:11:11 +0000
4@@ -10,6 +10,7 @@
5 os.getenv('RNR_LOGS_DIR', os.path.abspath(
6 os.path.join(BASE_DIR, os.path.pardir)) + '-logs'))
7 OOPS_DIR = os.path.join(LOGS_DIR, 'www-oops')
8+APP_LOGS_DIR = os.path.join(LOGS_DIR, 'www-logs')
9
10 ABSOLUTE_URL_OVERRIDES = {}
11 ADMINS = []
12@@ -257,7 +258,7 @@
13 'formatter': 'simple',
14 'class': 'logging.FileHandler',
15 'filters': '',
16- 'filename': os.path.join(LOGS_DIR, 'rnr.log'),
17+ 'filename': os.path.join(APP_LOGS_DIR, 'rnr.log'),
18 },
19 },
20 'incremental': False,

Subscribers

People subscribed via source and target branches

to all changes: