Ratings and Reviews server

Merge lp:~kelvin.li/rnr-server/charm-supports into lp:rnr-server

  1. charm-supports
  2. Merge into trunk
Proposed by Kelvin Li
Status: Merged
Approved by: Kelvin Li
Approved revision: 313
Merged at revision: 301
Proposed branch: lp:~kelvin.li/rnr-server/charm-supports
Merge into: lp:rnr-server
Diff against target: 108 lines (+12/-12)
2 files modified
Makefile (+2/-2)
src/reviewsapp/migrations/0013_add_debversion_field.py (+10/-10)
To merge this branch: bzr merge lp:~kelvin.li/rnr-server/charm-supports
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Review via email: mp+258579@code.launchpad.net

Commit message

change language 'C' to 'c' in migration file to fix LAUANGE 'C' doesn't existed error

Description of the change

One change from Postgres9.2 as following:
While unquoted language identifiers are still lowercased, strings and quoted identifiers are no longer forcibly down-cased. Thus for example CREATE FUNCTION ... LANGUAGE 'C' will no longer work; it must be spelled 'c', or better omit the quotes.

change language 'C' to 'c' in migration file to fix LAUANGE 'C' doesn't existed error. refer to [1]:

[1]http://www.postgresql.org/docs/current/interactive/release-9-2.html#AEN110228

To post a comment you must log in.
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Thanks for the detailed info above - I was going to ask whether the lowercase 'c' is compatible with the older version, but from your info, it is. Great.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2015-04-30 03:57:05 +0000
3+++ Makefile 2015-05-08 02:58:34 +0000
4@@ -68,9 +68,9 @@
5 touch $@
6
7 # use the flag file to avoid re-run config-manager if nothing changed
8-fetch-sourcedeps: branches/last_build version
9+fetch-sourcedeps: branches/last_build virtualenv version
10
11-sourcedeps: fetch-sourcedeps virtualenv install-virtualenv-requirements
12+sourcedeps: fetch-sourcedeps install-virtualenv-requirements
13
14 bootstrap: local-config sourcedeps
15
16
17=== modified file 'src/reviewsapp/migrations/0013_add_debversion_field.py'
18--- src/reviewsapp/migrations/0013_add_debversion_field.py 2014-09-24 22:39:43 +0000
19+++ src/reviewsapp/migrations/0013_add_debversion_field.py 2015-05-08 02:58:34 +0000
20@@ -81,7 +81,7 @@
21 CREATE OR REPLACE FUNCTION debversion_cmp (version1 debversion,
22 version2 debversion)
23 RETURNS integer AS '$libdir/debversion'
24- LANGUAGE 'C'
25+ LANGUAGE 'c'
26 IMMUTABLE STRICT;
27 COMMENT ON FUNCTION debversion_cmp (debversion, debversion)
28 IS 'Compare Debian versions';
29@@ -89,7 +89,7 @@
30 CREATE OR REPLACE FUNCTION debversion_eq (version1 debversion,
31 version2 debversion)
32 RETURNS boolean AS '$libdir/debversion'
33- LANGUAGE 'C'
34+ LANGUAGE 'c'
35 IMMUTABLE STRICT;
36 COMMENT ON FUNCTION debversion_eq (debversion, debversion)
37 IS 'debversion equal';
38@@ -97,7 +97,7 @@
39 CREATE OR REPLACE FUNCTION debversion_ne (version1 debversion,
40 version2 debversion)
41 RETURNS boolean AS '$libdir/debversion'
42- LANGUAGE 'C'
43+ LANGUAGE 'c'
44 IMMUTABLE STRICT;
45 COMMENT ON FUNCTION debversion_ne (debversion, debversion)
46 IS 'debversion not equal';
47@@ -105,7 +105,7 @@
48 CREATE OR REPLACE FUNCTION debversion_lt (version1 debversion,
49 version2 debversion)
50 RETURNS boolean AS '$libdir/debversion'
51- LANGUAGE 'C'
52+ LANGUAGE 'c'
53 IMMUTABLE STRICT;
54 COMMENT ON FUNCTION debversion_lt (debversion, debversion)
55 IS 'debversion less-than';
56@@ -113,7 +113,7 @@
57 CREATE OR REPLACE FUNCTION debversion_gt (version1 debversion,
58 version2 debversion)
59 RETURNS boolean AS '$libdir/debversion'
60- LANGUAGE 'C'
61+ LANGUAGE 'c'
62 IMMUTABLE STRICT;
63 COMMENT ON FUNCTION debversion_gt (debversion, debversion)
64 IS 'debversion greater-than';
65@@ -121,7 +121,7 @@
66 CREATE OR REPLACE FUNCTION debversion_le (version1 debversion,
67 version2 debversion)
68 RETURNS boolean AS '$libdir/debversion'
69- LANGUAGE 'C'
70+ LANGUAGE 'c'
71 IMMUTABLE STRICT;
72 COMMENT ON FUNCTION debversion_le (debversion, debversion)
73 IS 'debversion less-than-or-equal';
74@@ -129,7 +129,7 @@
75 CREATE OR REPLACE FUNCTION debversion_ge (version1 debversion,
76 version2 debversion)
77 RETURNS boolean AS '$libdir/debversion'
78- LANGUAGE 'C'
79+ LANGUAGE 'c'
80 IMMUTABLE STRICT;
81 COMMENT ON FUNCTION debversion_ge (debversion, debversion)
82 IS 'debversion greater-than-or-equal';
83@@ -206,7 +206,7 @@
84 CREATE OR REPLACE FUNCTION debversion_hash(debversion)
85 RETURNS int4
86 AS '$libdir/debversion'
87- LANGUAGE 'C'
88+ LANGUAGE 'c'
89 IMMUTABLE STRICT;
90
91 CREATE OPERATOR CLASS debversion_ops
92@@ -218,14 +218,14 @@
93 version2 debversion)
94 RETURNS debversion
95 AS '$libdir/debversion'
96- LANGUAGE 'C'
97+ LANGUAGE 'c'
98 IMMUTABLE STRICT;
99
100 CREATE OR REPLACE FUNCTION debversion_larger(version1 debversion,
101 version2 debversion)
102 RETURNS debversion
103 AS '$libdir/debversion'
104- LANGUAGE 'C'
105+ LANGUAGE 'c'
106 IMMUTABLE STRICT;
107
108 CREATE AGGREGATE min(debversion) (

Subscribers

People subscribed via source and target branches

to all changes: