Merge lp:~kelemeng/unity-greeter/bug831026 into lp:~robert-ancell/unity-greeter/trunk

Proposed by Gabor Kelemen
Status: Merged
Merged at revision: 90
Proposed branch: lp:~kelemeng/unity-greeter/bug831026
Merge into: lp:~robert-ancell/unity-greeter/trunk
Diff against target: 139 lines (+20/-9)
7 files modified
configure.ac (+1/-0)
po/POTFILES.in (+1/-0)
po/POTFILES.skip (+1/-0)
src/Makefile.am (+1/-0)
src/config.vapi (+1/-0)
src/unity-greeter.vala (+12/-7)
src/user-list.vala (+3/-2)
To merge this branch: bzr merge lp:~kelemeng/unity-greeter/bug831026
Reviewer Review Type Date Requested Status
Robert Ancell Pending
Review via email: mp+72457@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Fixed with minor changes:
- Remove tab character
- Remove unnecessary variable 'txt'

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2011-08-09 14:43:44 +0000
3+++ configure.ac 2011-08-22 16:25:17 +0000
4@@ -29,6 +29,7 @@
5 IT_PROG_INTLTOOL(0.35.0)
6 GETTEXT_PACKAGE=unity-greeter
7 AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", Gettext package)
8+AC_SUBST(GETTEXT_PACKAGE)
9
10 dnl ###########################################################################
11 dnl Files to generate
12
13=== modified file 'po/POTFILES.in'
14--- po/POTFILES.in 2011-07-13 03:09:52 +0000
15+++ po/POTFILES.in 2011-08-22 16:25:17 +0000
16@@ -1,3 +1,4 @@
17 # List of source files containing translatable strings.
18 # Please keep this file sorted alphabetically.
19 src/unity-greeter.vala
20+src/user-list.vala
21
22=== modified file 'po/POTFILES.skip'
23--- po/POTFILES.skip 2011-07-13 03:09:52 +0000
24+++ po/POTFILES.skip 2011-08-22 16:25:17 +0000
25@@ -1,1 +1,2 @@
26 src/unity-greeter.c
27+src/user-list.c
28
29=== modified file 'src/Makefile.am'
30--- src/Makefile.am 2011-07-26 04:21:25 +0000
31+++ src/Makefile.am 2011-08-22 16:25:17 +0000
32@@ -11,6 +11,7 @@
33 $(UNITY_GREETER_CFLAGS) \
34 $(WARN_CFLAGS) \
35 -DGETTEXT_PACKAGE=\"$(GETTEXT_PACKAGE)\" \
36+ -DLOCALEDIR=\""$(localedir)"\" \
37 -DVERSION=\"$(VERSION)\" \
38 -DCONFIG_FILE=\""$(sysconfdir)/lightdm/unity-greeter.conf"\"
39
40
41=== modified file 'src/config.vapi'
42--- src/config.vapi 2011-07-26 00:29:18 +0000
43+++ src/config.vapi 2011-08-22 16:25:17 +0000
44@@ -2,6 +2,7 @@
45 namespace Config
46 {
47 public const string GETTEXT_PACKAGE;
48+ public const string LOCALEDIR;
49 public const string VERSION;
50 public const string CONFIG_FILE;
51 }
52
53=== modified file 'src/unity-greeter.vala'
54--- src/unity-greeter.vala 2011-08-22 03:39:03 +0000
55+++ src/unity-greeter.vala 2011-08-22 16:25:17 +0000
56@@ -78,8 +78,8 @@
57 user_list.add_entry ("alice", "Alice User", "/usr/share/backgrounds/Berries_by_Orb9220.jpg", true);
58 user_list.add_entry ("bob", "Bob User", "/usr/share/backgrounds/White_flowers_by_Garuna_bor-bor.jpg");
59 user_list.add_entry ("carol", "Carol User", "/usr/share/backgrounds/Bird_by_Magnus.jpg");
60- user_list.add_entry ("*guest", "Guest Account", null, true);
61- user_list.add_entry (null, "Other...");
62+ user_list.add_entry ("*guest", _("Guest Account"), null, true);
63+ user_list.add_entry (null, _("Other..."));
64
65 user_list.add_session ("gnome", "Ubuntu");
66 user_list.add_session ("gnome-shell", "GNOME");
67@@ -96,8 +96,8 @@
68 user_list.add_entry (user.name, label, null);
69 }
70 if (greeter.has_guest_account_hint)
71- user_list.add_entry ("*guest", "Guest Account", null);
72- user_list.add_entry (null, "Other...");
73+ user_list.add_entry ("*guest", _("Guest Account"), null);
74+ user_list.add_entry (null, _("Other..."));
75 }
76
77 main_window = new Gtk.Window ();
78@@ -214,7 +214,7 @@
79 test_is_authenticated = false;
80
81 if (user_list.selected == null)
82- show_prompt_cb ("Username:", LightDM.PromptType.QUESTION);
83+ show_prompt_cb (_("Username:"), LightDM.PromptType.QUESTION);
84 else if (user_list.selected == "*guest" || user_list.selected == "bob")
85 {
86 test_is_authenticated = true;
87@@ -223,7 +223,7 @@
88 else
89 {
90 test_username = user_list.selected;
91- show_prompt_cb ("Password:", LightDM.PromptType.SECRET);
92+ show_prompt_cb (_("Password:"), LightDM.PromptType.SECRET);
93 }
94 }
95 else
96@@ -248,7 +248,7 @@
97 {
98 debug ("username=%s", text);
99 test_username = text;
100- show_prompt_cb ("Password:", LightDM.PromptType.SECRET);
101+ show_prompt_cb (_("Password:"), LightDM.PromptType.SECRET);
102 }
103 else
104 {
105@@ -335,6 +335,11 @@
106 /* Disable the stupid global menubar */
107 Environment.unset_variable ("UBUNTU_MENUPROXY");
108
109+ /* Initialize i18n */
110+ Intl.bindtextdomain (Config.GETTEXT_PACKAGE, Config.LOCALEDIR);
111+ Intl.bind_textdomain_codeset (Config.GETTEXT_PACKAGE, "UTF-8");
112+ Intl.textdomain (Config.GETTEXT_PACKAGE);
113+
114 Gtk.init (ref args);
115
116 /* Set the cursor to not be the crap default */
117
118=== modified file 'src/user-list.vala'
119--- src/user-list.vala 2011-08-22 05:20:25 +0000
120+++ src/user-list.vala 2011-08-22 16:25:17 +0000
121@@ -129,7 +129,8 @@
122 add (prompt_entry);
123
124 login_button = new Gtk.Button ();
125- var label = new Gtk.Label ("<span font_size=\"large\">Login</span>");
126+ string txt = "<span font_size=\"large\">" + _("Login") + "</span>";
127+ var label = new Gtk.Label (txt);
128 label.use_markup = true;
129 label.show ();
130 login_button.add (label);
131@@ -216,7 +217,7 @@
132 sensitive = false;
133
134 error = null;
135- message = "Logging in...";
136+ message = _("Logging in...");
137
138 login_button.hide ();
139 prompt_entry.hide ();

Subscribers

People subscribed via source and target branches

to all changes: