Ubuntu Software Center

Merge lp:~kelemeng/software-center/bug868971 into lp:software-center

  1. bug868971
  2. Merge into trunk
Proposed by Gabor Kelemen
Status: Merged
Merged at revision: 2594
Proposed branch: lp:~kelemeng/software-center/bug868971
Merge into: lp:software-center
Diff against target: 13 lines (+2/-1)
1 file modified
softwarecenter/ui/gtk3/views/catview_gtk.py (+2/-1)
To merge this branch: bzr merge lp:~kelemeng/software-center/bug868971
Reviewer Review Type Date Requested Status
Michael Vogt Approve
Review via email: mp+85265@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for this branch merge request. The diff shows up as empty, did you maybe forgot to push the correct revision?

review: Needs Information
lp:~kelemeng/software-center/bug868971 updated
2592. By Gabor Kelemen

Add a translator comment to the 'Top Rated %s' string, name the variable. LP: #868971

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

Oh yes, sorry. I have mistyped the commit command and didn't saw the error message. It should be good now.

Revision history for this message
Michael Vogt (mvo) wrote :

Looks great, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/ui/gtk3/views/catview_gtk.py'
2--- softwarecenter/ui/gtk3/views/catview_gtk.py 2011-10-05 09:18:03 +0000
3+++ softwarecenter/ui/gtk3/views/catview_gtk.py 2011-12-12 10:29:38 +0000
4@@ -582,7 +582,8 @@
5 def _update_sub_toprated_content(self, category):
6 self.toprated.remove_all()
7 # FIXME: should this be m = "%s %s" % (_(gettext text), header text) ??
8- m = _('Top Rated %s') % GObject.markup_escape_text(self.header)
9+ # TRANSLATORS: %s is a category name, like Internet or Development Tools
10+ m = _('Top Rated %(category)s') % { 'category' : GObject.markup_escape_text(self.header)}
11 self.toprated_frame.set_header_label(m)
12 docs = self._get_sub_toprated_content(category)
13 self._add_tiles_to_flowgrid(docs, self.toprated, TOP_RATED_CAROUSEL_LIMIT)