Merge lp:~kelemeng/activity-log-manager/i18n-fixes into lp:~activity-log-manager/activity-log-manager/vala

Proposed by Gabor Kelemen
Status: Merged
Merged at revision: 95
Proposed branch: lp:~kelemeng/activity-log-manager/i18n-fixes
Merge into: lp:~activity-log-manager/activity-log-manager/vala
Diff against target: 60 lines (+12/-6)
3 files modified
po/POTFILES.in (+2/-1)
src/diagnostics/Makefile.am (+8/-3)
src/diagnostics/com.ubuntu.whoopsiepreferences.policy.in (+2/-2)
To merge this branch: bzr merge lp:~kelemeng/activity-log-manager/i18n-fixes
Reviewer Review Type Date Requested Status
Manish Sinha (मनीष सिन्हा) i18n Approve
Daniel Holbach (community) Approve
Review via email: mp+95472@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Daniel Holbach (dholbach) wrote :

Great work, thanks! I took the liberty to write a debian/changelog entry for you and massage your changes into a distro patch - I hope this will be picked up upstream soon.

review: Approve
Revision history for this message
Manish Sinha (मनीष सिन्हा) (manishsinha) wrote :

Looks great. Thanks

------------------------------------------------------------
revno: 97
committer: Manish Sinha <email address hidden>
branch nick: alm
timestamp: Fri 2012-03-02 21:11:12 +0530
message:
  Add Gabor Kelemen to AUTHORS
------------------------------------------------------------
revno: 96
committer: Manish Sinha <email address hidden>
branch nick: alm
timestamp: Fri 2012-03-02 21:09:07 +0530
message:
  Bump 0.9.2 to 0.9.3
------------------------------------------------------------
revno: 95 [merge]
fixes bug: https://launchpad.net/bugs/944362
committer: Manish Sinha <email address hidden>
branch nick: alm
timestamp: Fri 2012-03-02 21:08:11 +0530
message:
  Fix the i18n issues in alm. See the bug LP #944362
------------------------------------------------------------

review: Approve (i18n)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'po/POTFILES.in'
2--- po/POTFILES.in 2012-02-20 18:36:10 +0000
3+++ po/POTFILES.in 2012-03-01 21:36:27 +0000
4@@ -6,4 +6,5 @@
5 src/applications-widget.vala
6 src/files-widget.vala
7 src/history-widget.vala
8-src/diagnostics/whoopsie.ui
9+src/diagnostics/com.ubuntu.whoopsiepreferences.policy.in
10+[type: gettext/glade]src/diagnostics/whoopsie.ui
11
12=== modified file 'src/diagnostics/Makefile.am'
13--- src/diagnostics/Makefile.am 2012-02-20 17:24:27 +0000
14+++ src/diagnostics/Makefile.am 2012-03-01 21:36:27 +0000
15@@ -20,17 +20,20 @@
16 $(POLKIT_LIBS) \
17 $(GIO_UNIX_LIBS)
18
19+policykit_in_files = \
20+ com.ubuntu.whoopsiepreferences.policy.in
21+
22 EXTRA_DIST = \
23 whoopsie-preferences.xml \
24 com.ubuntu.WhoopsiePreferences.service \
25 com.ubuntu.WhoopsiePreferences.conf \
26- com.ubuntu.whoopsiepreferences.policy \
27+ $(policykit_in_files) \
28 whoopsie.ui
29
30 gnomeccui_DATA = \
31 whoopsie.ui
32 policykit_DATA = \
33- com.ubuntu.whoopsiepreferences.policy
34+ $(policykit_in_files:.policy.in=.policy)
35 dbussystem_DATA = \
36 com.ubuntu.WhoopsiePreferences.conf
37 dbusservice_DATA = \
38@@ -41,4 +44,6 @@
39 --generate-c-code whoopsie-generated \
40 $<
41
42-CLEANFILES = whoopsie-generated.[ch]
43+CLEANFILES = whoopsie-generated.[ch] \
44+ $(policykit_DATA)
45+@INTLTOOL_POLICY_RULE@
46
47=== renamed file 'src/diagnostics/com.ubuntu.whoopsiepreferences.policy' => 'src/diagnostics/com.ubuntu.whoopsiepreferences.policy.in'
48--- src/diagnostics/com.ubuntu.whoopsiepreferences.policy 2012-02-20 09:51:28 +0000
49+++ src/diagnostics/com.ubuntu.whoopsiepreferences.policy.in 2012-03-01 21:36:27 +0000
50@@ -7,8 +7,8 @@
51 <vendor_url>https://launchpad.net/whoopsie-daisy</vendor_url>
52 <icon_name>stock_lock</icon_name>
53 <action id="com.ubuntu.whoopsiepreferences.change">
54- <description gettext-domain="whoopsie">Privacy settings</description>
55- <message gettext-domain="whoopsie">To change your privacy settings you need to authenticate.</message>
56+ <_description>Privacy settings</_description>
57+ <_message>To change your privacy settings you need to authenticate.</_message>
58 <defaults>
59 <allow_any>auth_admin</allow_any>
60 <allow_inactive>auth_admin</allow_inactive>

Subscribers

People subscribed via source and target branches