Code review comment for lp:~kelemeng/activity-log-manager/bug958483

Revision history for this message
Gabor Kelemen (kelemeng) wrote :

>> var last_accessed = time.format(_("%e %B %Y"));

> These are string formatting for how the time should be rendered. It doesn't get printed on the
> screen. It doesn't need to be translated.

The date gets printed in a format specified by these strings. Preferred date formats are different in various languages, so formatting strings needs to be marked for translation.

This is covered here: http://www.gnu.org/software/gettext/manual/gettext.html#Aspects

As for Stefanoss branch: you missed the untranslated Name string in the ApplicationsTreeView class. This is not visible, but it is an accessible description of the blacklisted applications list, and can be heard when using Orca.

Also you should mark the time formatting strings for translation too. Also please avoid using string surgeries like:

time.format(today + ", %H:%M")

This won't look good in some languages, even if the two parts would be translatable individually. See: https://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences

« Back to merge proposal