Code review comment for lp:~kelemeng/activity-log-manager/bug958483

Revision history for this message
Stefano Candori (cando) wrote :

Manish, those gettext changes are already in my branch.. could you review
my merge request?

Stefano Candori
Il giorno 18/mar/2012 19:47, "Manish Sinha (मनीष सिन्हा" <
<email address hidden>> ha scritto:

> Review: Needs Fixing
>
> > var last_accessed = time.format(_("%e %B %Y"));
>
> These are string formatting for how the time should be rendered. It
> doesn't get printed on the screen. It doesn't need to be translated.
>
> > var date_string = date.format(_("%d %B %Y"));
> Same
>
> > var date_string = date.format(_("%d %B %Y"));
> Same
> --
>
> https://code.launchpad.net/~kelemeng/activity-log-manager/bug958483/+merge/98096
> Your team Activity Log Manager is subscribed to branch
> lp:activity-log-manager.
>

« Back to merge proposal