Merge lp:~kdub/platform-api/mir-deb-bump-0.1.3 into lp:platform-api

Proposed by Kevin DuBois
Status: Merged
Merged at revision: 179
Proposed branch: lp:~kdub/platform-api/mir-deb-bump-0.1.3
Merge into: lp:platform-api
Diff against target: 70 lines (+6/-7)
4 files modified
debian/control (+2/-2)
src/ubuntu/mirserver/ubuntu_application_api_mirserver.cpp (+1/-1)
src/ubuntu/mirserver/window_properties_mirserver.cpp (+1/-2)
src/ubuntu/mirserver/window_properties_mirserver_priv.h (+2/-2)
To merge this branch: bzr merge lp:~kdub/platform-api/mir-deb-bump-0.1.3
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+200430@code.launchpad.net

This proposal supersedes a proposal from 2014-01-02.

Commit message

bump debian version dependency for mir to 0.1.3 to force rebuild

Description of the change

bump debian version dependency for mir to 0.1.3 to force rebuild

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

@kgunn
seems there was some abi breakage, so updating the versioning only was insufficient. Fixed the ftbfs, seeing as you're out sick and this probably blocks a fair amount of stuff

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Kevin DuBois (kdub) wrote :

I'm a bit unfamiliar with committing to platform-api, should we bump debian/changlog too?

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

On 03/01/14 20:35, Kevin DuBois wrote:
> I'm a bit unfamiliar with committing to platform-api, should we bump debian/changlog too?
No, that should be done from the daily release

Revision history for this message
Allan LeSage (allanlesage) wrote :

+1'ing this as it blocks an MP of mine--could we get someone qualified to review?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-11-22 16:01:19 +0000
3+++ debian/control 2014-01-03 19:19:04 +0000
4@@ -11,8 +11,8 @@
5 g++-4.7,
6 libhybris-common-dev,
7 pkg-config,
8- libmirclient-dev (>= 0.1.2),
9- libmirserver-dev (>= 0.1.2),
10+ libmirclient-dev (>= 0.1.3),
11+ libmirserver-dev (>= 0.1.3),
12 liburl-dispatcher1-dev,
13 libdbus-1-dev,
14 dbus-cpp-dev,
15
16=== modified file 'src/ubuntu/mirserver/ubuntu_application_api_mirserver.cpp'
17--- src/ubuntu/mirserver/ubuntu_application_api_mirserver.cpp 2013-08-23 02:21:20 +0000
18+++ src/ubuntu/mirserver/ubuntu_application_api_mirserver.cpp 2014-01-03 19:19:04 +0000
19@@ -214,7 +214,7 @@
20
21 namespace
22 {
23-static mir::geometry::PixelFormat choose_pixel_format(std::shared_ptr<mir::graphics::GraphicBufferAllocator> const& allocator)
24+static MirPixelFormat choose_pixel_format(std::shared_ptr<mir::graphics::GraphicBufferAllocator> const& allocator)
25 {
26 auto formats = allocator->supported_pixel_formats();
27 return formats[0];
28
29=== modified file 'src/ubuntu/mirserver/window_properties_mirserver.cpp'
30--- src/ubuntu/mirserver/window_properties_mirserver.cpp 2013-06-10 03:30:30 +0000
31+++ src/ubuntu/mirserver/window_properties_mirserver.cpp 2014-01-03 19:19:04 +0000
32@@ -22,7 +22,6 @@
33
34 namespace uams = ubuntu::application::mir::server;
35 namespace msh = mir::shell;
36-namespace geom = mir::geometry;
37
38 uams::WindowProperties::WindowProperties()
39 : parameters(msh::a_surface()),
40@@ -52,7 +51,7 @@
41 input_ctx = ctx;
42 }
43
44-void uams::WindowProperties::set_pixel_format(geom::PixelFormat const& format)
45+void uams::WindowProperties::set_pixel_format(MirPixelFormat const& format)
46 {
47 parameters = parameters.of_pixel_format(format);
48 }
49
50=== modified file 'src/ubuntu/mirserver/window_properties_mirserver_priv.h'
51--- src/ubuntu/mirserver/window_properties_mirserver_priv.h 2013-06-09 23:54:39 +0000
52+++ src/ubuntu/mirserver/window_properties_mirserver_priv.h 2014-01-03 19:19:04 +0000
53@@ -22,7 +22,7 @@
54 #include <ubuntu/application/ui/window.h>
55
56 #include <mir/shell/surface_creation_parameters.h>
57-#include <mir/geometry/pixel_format.h>
58+#include <mir_toolkit/client_types.h>
59
60 namespace ubuntu
61 {
62@@ -44,7 +44,7 @@
63
64 void set_title(char const* title, size_t length);
65 void set_input_cb_and_ctx(UAUiWindowInputEventCb cb, void* ctx);
66- void set_pixel_format( ::mir::geometry::PixelFormat const& format);
67+ void set_pixel_format( MirPixelFormat const& format);
68
69 ::mir::shell::SurfaceCreationParameters const& surface_parameters() const;
70 UAUiWindowInputEventCb input_cb() const;

Subscribers

People subscribed via source and target branches