Mir

Merge lp:~kdub/mir/remove-get-buffer-usage into lp:~mir-team/mir/publish-new-apis

Proposed by Kevin DuBois
Status: Rejected
Rejected by: Cemil Azizoglu
Proposed branch: lp:~kdub/mir/remove-get-buffer-usage
Merge into: lp:~mir-team/mir/publish-new-apis
Diff against target: 35 lines (+0/-14)
2 files modified
src/client/mir_buffer_api.cpp (+0/-13)
src/client/symbols.map (+0/-1)
To merge this branch: bzr merge lp:~kdub/mir/remove-get-buffer-usage
Reviewer Review Type Date Requested Status
Cemil Azizoglu (community) Abstain
Review via email: mp+316230@code.launchpad.net

Commit message

remove mir_buffer_get_buffer_usage from gated api before publishing.

Description of the change

remove mir_buffer_get_buffer_usage from gated api before publishing.

To post a comment you must log in.
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Already in there

review: Abstain

Unmerged revisions

3956. By Kevin DuBois

remove get buffer usage api

3955. By Cemil Azizoglu

Fix clang build.

3954. By Cemil Azizoglu

Merge lp:mir... no conflicts!?

3953. By Cemil Azizoglu

Deprecate types too.

3952. By Cemil Azizoglu

Merge lp:mir, fix conflict again.

3951. By Cemil Azizoglu

merge lp:mir, fix conflict

3950. By Cemil Azizoglu

More cleanups

3949. By Cemil Azizoglu

"Staging" can now use the published headers

3948. By Cemil Azizoglu

Unversion and ignore version.h

3947. By Cemil Azizoglu

Publishing new APIs

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/client/mir_buffer_api.cpp'
2--- src/client/mir_buffer_api.cpp 2017-01-30 08:13:20 +0000
3+++ src/client/mir_buffer_api.cpp 2017-02-02 13:58:22 +0000
4@@ -168,19 +168,6 @@
5 return mir_pixel_format_invalid;
6 }
7
8-MirBufferUsage mir_buffer_get_buffer_usage(MirBuffer* b)
9-try
10-{
11- mir::require(b);
12- auto buffer = reinterpret_cast<mcl::MirBuffer*>(b);
13- return buffer->buffer_usage();
14-}
15-catch (std::exception const& ex)
16-{
17- MIR_LOG_UNCAUGHT_EXCEPTION(ex);
18- return mir_buffer_usage_hardware;
19-}
20-
21 bool mir_buffer_is_valid(MirBuffer* b)
22 try
23 {
24
25=== modified file 'src/client/symbols.map'
26--- src/client/symbols.map 2017-02-01 22:28:16 +0000
27+++ src/client/symbols.map 2017-02-02 13:58:22 +0000
28@@ -585,7 +585,6 @@
29 mir_buffer_get_width;
30 mir_buffer_get_height;
31 mir_buffer_get_pixel_format;
32- mir_buffer_get_buffer_usage;
33 mir_buffer_is_valid;
34 mir_buffer_get_error_message;
35 mir_buffer_get_buffer_package;

Subscribers

People subscribed via source and target branches