Mir

Code review comment for lp:~kdub/mir/mali-client-render-support

Revision history for this message
Kevin DuBois (kdub) wrote :

> Looks good.
>
> + anwb->stride = stride.as_uint32_t();
>
> So, is the ANativeWindowBuffer stride in bytes after all, or it's only there
> for the benefit of the users and the driver doesn't care about the value?

Let me dig a bit on this question before we land this. I did a quick check on my devices... nexus4 seems to pass the stride in through the opaque handle (so it doesn't care about this field), nexus10 seems to prefer bytes, but maguro seems to prefer pixels... will post an update once i've sorted this out

review: Needs Fixing

« Back to merge proposal