Mir

Merge lp:~kdub/mir/fix-1447729 into lp:mir

Proposed by Kevin DuBois
Status: Merged
Approved by: Kevin DuBois
Approved revision: no longer in the source branch.
Merged at revision: 2511
Proposed branch: lp:~kdub/mir/fix-1447729
Merge into: lp:mir
Diff against target: 34 lines (+12/-2)
1 file modified
cmake/ABICheck.cmake (+12/-2)
To merge this branch: bzr merge lp:~kdub/mir/fix-1447729
Reviewer Review Type Date Requested Status
Cemil Azizoglu (community) Approve
Alexandros Frantzis (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+257286@code.launchpad.net

Commit message

build system: fix the MIR_PLATFORM cmake variable if defined to MIR_PLATFORM=android or MIR_PLATFORM=mesa.

fixes: lp: #1447729

Description of the change

build system: fix the MIR_PLATFORM cmake variable if defined to MIR_PLATFORM=android or MIR_PLATFORM=mesa.

fixes: lp: #1447729

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

Looks good.

review: Approve
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Ok

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cmake/ABICheck.cmake'
2--- cmake/ABICheck.cmake 2015-04-09 06:20:31 +0000
3+++ cmake/ABICheck.cmake 2015-04-23 18:04:18 +0000
4@@ -80,10 +80,14 @@
5 make_lib_descriptor(server)
6 make_lib_descriptor(common INCLUDE_PRIVATE EXCLUDE_HEADERS ${mircommon-exclude-headers})
7 make_lib_descriptor(platform INCLUDE_PRIVATE EXCLUDE_HEADERS ${mirplatform-exclude-headers})
8+if(MIR_BUILD_PLATFORM_MESA)
9 make_lib_descriptor(clientplatformmesa LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/src/include/client/mir/client_platform_factory.h)
10+make_lib_descriptor(platformgraphicsmesa LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/include/platform/mir/graphics/platform.h)
11+endif()
12+if(MIR_BUILD_PLATFORM_ANDROID)
13 make_lib_descriptor(clientplatformandroid LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/src/include/client/mir/client_platform_factory.h)
14-make_lib_descriptor(platformgraphicsmesa LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/include/platform/mir/graphics/platform.h)
15 make_lib_descriptor(platformgraphicsandroid LIBRARY_HEADER ${CMAKE_SOURCE_DIR}/include/platform/mir/graphics/platform.h)
16+endif()
17
18 add_custom_target(abi-release-dump
19 COMMAND /bin/sh -c '${CMAKE_SOURCE_DIR}/tools/generate-abi-base-dump.sh ${CMAKE_SOURCE_DIR}'
20@@ -120,7 +124,13 @@
21 )
22 endmacro(_define_abi_check_for)
23
24-set(the_libs mirserver mirclient mircommon mirplatform mirclientplatformmesa mirclientplatformandroid mirplatformgraphicsmesa mirplatformgraphicsandroid)
25+set(the_libs mirserver mirclient mircommon mirplatform)
26+if(MIR_BUILD_PLATFORM_MESA)
27+ set(the_libs ${the_libs} mirclientplatformmesa mirplatformgraphicsmesa)
28+endif()
29+if(MIR_BUILD_PLATFORM_ANDROID)
30+ set(the_libs ${the_libs} mirclientplatformandroid mirplatformgraphicsandroid)
31+endif()
32
33 foreach(libname ${the_libs})
34 _define_abi_dump_for(${libname})

Subscribers

People subscribed via source and target branches