lp:~kdub/mir/fix-1373698

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:mir

Daniel van Vugt: Disapprove on 2014-09-26

PS Jenkins bot (community): Needs Fixing (continuous-integration) on 2014-09-25

Diff: 134 lines (+47/-4)

7 files modified

include/platform/mir/graphics/renderable.h (+3/-0)
platform-ABI-sha1sums (+1/-1)
server-ABI-sha1sums (+1/-1)
src/server/compositor/gl_renderer.cpp (+1/-1)
src/server/input/touchspot_controller.cpp (+1/-1)
tests/unit-tests/compositor/test_gl_renderer.cpp (+24/-0)
tests/unit-tests/input/test_touchspot_controller.cpp (+16/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1373698: Touchspots are rendered as squares

Medium

Fix Released

Link a bug report

Related blueprints

1944. By Kevin DuBois on 2014-09-25

update sha1sums (no ABI break, just updating comment)

1943. By Kevin DuBois on 2014-09-25

update comment in header

1942. By Kevin DuBois on 2014-09-25

test to pass

1941. By Kevin DuBois on 2014-09-25

add a failing test that checks that the renderable has alpha_enabled

1940. By Kevin DuBois on 2014-09-25

test to pass

1939. By Kevin DuBois on 2014-09-25

add a failing test so that the GLRenderer will disable blending if alpha_enabled is not set

1938. By Kevin DuBois on 2014-09-25

frontend: platform: provide a way for the frontend to perform platform specific actions upon receipt of buffer from the client. Split out the 3 platform ipc operations into its own interface.

I renamed: BufferIPCPacker -> BufferIpcMessage. (packing is what it does, a message is what it is)

I made note that drm_auth_magic() should also be a function in the PlatformIpcOperations interface, this would remove the mg::Platform from the frontend altogether.

Approved by Chris Halse Rogers, Robert Carr, Alexandros Frantzis.

1937. By Daniel van Vugt on 2014-09-25

Reduced visible input lag by approx one frame (on 59-60Hz displays)*

It's not enough to resample input down to a rate similar to the refresh
rate. That only reduces your lag from "always growing" to a constant one
frame.

This proposal reduces lag further to almost zero, by periodically (five
times per second) bringing the cooked event interval in-phase with the
refresh rate. Thus about every 12th frame, the client is able to respond
to an input event and get composited with one frame less buffer lag than
before.

* Displays >>60Hz will already be experiencing this trick and won't
  benefit further.
.

Approved by Alexandros Frantzis, Kevin DuBois.

1936. By Daniel van Vugt on 2014-09-25

Fix jerky/stuttering event delivery that could happen inside
nested servers sometimes (LP: #1372300)

Waiting significantly longer than a frame before consuming previously
batched events is too dangerous in slow raw-event environments
(nested servers or very slow input devices). It causes frame skipping.
. Fixes: https://bugs.launchpad.net/bugs/1372300.

Approved by Alexandros Frantzis.

1935. By Robert Carr on 2014-09-25

Ensure touchspots do not update the scene when disabled

Fixes LP: #1372850 and LP: #1373689 at least when touchspots are disabled. Fixes: https://bugs.launchpad.net/bugs/1372850, https://bugs.launchpad.net/bugs/1373689.

Approved by PS Jenkins bot, Daniel van Vugt.