Mir

Merge lp:~kdub/mir/fix-1312867 into lp:mir

  1. fix-1312867
  2. Merge into development-branch
Proposed by Kevin DuBois
Status: Merged
Approved by: Daniel van Vugt
Approved revision: no longer in the source branch.
Merged at revision: 1576
Proposed branch: lp:~kdub/mir/fix-1312867
Merge into: lp:mir
Diff against target: 11 lines (+1/-1)
1 file modified
src/platform/graphics/android/framebuffers.cpp (+1/-1)
To merge this branch: bzr merge lp:~kdub/mir/fix-1312867
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Cemil Azizoglu (community) Approve
Alberto Aguirre (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+217294@code.launchpad.net

Commit message

fix a valgrind complaint about uninitialized memory.

fixes: lp: #1312867

Description of the change

fix a valgrind complaint about uninitialized memory.

fixes: lp: #1312867

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1576
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/1408/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1717
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1715
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/1287
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/1140
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/1140/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/1145
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/1145/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/1290
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/1290/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/1188
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/6432

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1408/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

LGTM

review: Approve
Revision history for this message
Cemil Azizoglu (cemil-azizoglu) wrote :

Good to go!

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/platform/graphics/android/framebuffers.cpp'
2--- src/platform/graphics/android/framebuffers.cpp 2014-04-15 05:31:19 +0000
3+++ src/platform/graphics/android/framebuffers.cpp 2014-04-25 20:23:20 +0000
4@@ -94,7 +94,7 @@
5 HWC_DISPLAY_NO_ATTRIBUTE,
6 };
7
8- int32_t size_values[sizeof(display_attribute_request) / sizeof (display_attribute_request[0])];
9+ int32_t size_values[sizeof(display_attribute_request) / sizeof (display_attribute_request[0])] = {};
10 hwc_device->getDisplayAttributes(hwc_device.get(), HWC_DISPLAY_PRIMARY, primary_display_config,
11 display_attribute_request, size_values);
12

Subscribers

People subscribed via source and target branches