Merge lp:~kdub/mir/fix-1301040 into lp:mir

[Kevin DuBois]

unity8 was hitting a case where the dlopen-ed libmirplatformgraphics.so would fail to find some symbols for boost program options. Make sure libboost_program_options.*.so appears in the symbol table of this library.

fixes lp: #1301040

unity8 was hitting a case where the dlopen-ed libmirplatformgraphics.so would fail to find some symbols for boost program options. Make sure libboost_program_options.*.so appears in the symbol table of this library.

fixes lp: #1301040

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1522
http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-ci/1218/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-android-trusty-i386-build/1444
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-clang-trusty-amd64-build/1442
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-trusty-touch/1022
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/950
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-amd64-ci/950/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/955
        deb: http://jenkins.qa.ubuntu.com/job/mir-team-mir-development-branch-trusty-armhf-ci/955/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/1023
        deb: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-builder-trusty-armhf/1023/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/mir-mediumtests-runner-mako/950
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/5533

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/mir-team-mir-development-branch-ci/1218/rebuild

review: Approve (continuous-integration)

[Daniel van Vugt (vanvugt)]

It *looks* like kdub meant to put this up for review, so I'm setting it as so.

[Daniel d'Andrada (dandrader)]

34 + ${Boost_PROGRAM_OPTIONS_LIBRARY}

Some trailing whitespace here

[Daniel d'Andrada (dandrader)]

It improves the situation but doesn't fix it.

unity8 now crashes on mir::options missing symbols:

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<std::runtime_error> >'
  what(): /usr/lib/arm-linux-gnueabihf/mir/platformgraphics/android/libmirplatformgraphics.so: undefined symbol: _ZN3mir7options13off_opt_valueE

Following racarr's hint, what solved for me (as a workaround) was running unity8 with:
LD_PRELOAD=/usr/lib/arm-linux-gnueabihf/libmirserver.so.18

Because if I add miroption to mirplatformgraphics's target_link_libraries then I get yet another missing symbol from another lib (mir socket IIRC).

I'm running unity8 with the "Qt as mir compositor" Qt platform plugin (instead of the regular one from qtubuntu package), if that makes any difference...

review: Needs Fixing

[Daniel d'Andrada (dandrader)]

Wild guess: might be related with the order in which libs are loaded? ie, ensuring libmirserver is loaded before dlopening libmirplatformgraphics.so?

[Alan Griffiths (alan-griffiths)]

It sounds like we need an audit of symbols provided by/used by our libraries so that we can propose a robust solution.

review: Needs Information

[Kevin DuBois (kdub)]

> It *looks* like kdub meant to put this up for review, so I'm setting it as so.

I hadn't confirmed that it fixed (had to rebuild the stack), so I had as WIP until I could get a confirmation. As it turns out, it did not fix the problem completely, so still WIP.

[Kevin DuBois (kdub)]

rejected in favor of mterry's fix

Unmerged revisions

1522. By Kevin DuBois on 2014-04-01

make sure libboost_program_options is in the libmirplatformgraphics.so dynamic section

=== modified file 'src/platform/graphics/CMakeLists.txt'
--- src/platform/graphics/CMakeLists.txt	2014-03-10 03:02:32 +0000
+++ src/platform/graphics/CMakeLists.txt	2014-04-01 22:28:40 +0000
@@ -24,6 +24,7 @@
   mirsharedgeometry
 
   ${EGL_LDFLAGS} ${EGL_LIBRARIES}
+  ${Boost_PROGRAM_OPTIONS_LIBRARY}  
 )
 
 if (MIR_BUILD_PLATFORM_ANDROID)

=== modified file 'src/platform/options/CMakeLists.txt'
--- src/platform/options/CMakeLists.txt	2014-03-06 06:05:17 +0000
+++ src/platform/options/CMakeLists.txt	2014-04-01 22:28:40 +0000
@@ -1,5 +1,5 @@
 set(
-  CHOICE_SOURCES
+  OPTIONS_SOURCES
 
   program_option.cpp
   default_configuration.cpp
@@ -8,5 +8,11 @@
 add_library(
   miroptions STATIC
 
-  ${CHOICE_SOURCES}
+  ${OPTIONS_SOURCES}
+)
+
+target_link_libraries(
+  miroptions
+
+  ${Boost_PROGRAM_OPTIONS_LIBRARY}  
 )