Merge lp:~kaxing/checkbox/fix-1318538 into lp:checkbox

[kaxing]

To make "success" variable able to use in SubmissionDialog, I've declared "success" as a property attribute in "updater" object, so we can use updater.success in other dialog.

[Brendan Donegan (brendan-donegan)]

Please use runmanagerview.success, as in SubmissionDialog.qml:

136 + if (success) {
137 + runmanagerview.reportIsSaved = success;
138 + }

review: Needs Fixing

[Brendan Donegan (brendan-donegan)]

Actually ignore that - but I'm not sure updater is the right place.

[Brendan Donegan (brendan-donegan)]

review: Abstain

[Daniel Manrique (roadmr)]

+1, tested "in the field" and it works OK, plus without this, we can't even submit, so let's go ahead.

review: Approve

[Daniel Manrique (roadmr)]

The attempt to merge lp:~kaxing/checkbox/fix-1318538 into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'

[Daniel Manrique (roadmr)]

reapproving due to the tarmac failure.

review: Approve

[Daniel Manrique (roadmr)]

The attempt to merge lp:~kaxing/checkbox/fix-1318538 into lp:checkbox failed. Below is the output from the failed tests.

[precise] Bringing VM 'up'
[precise] Unable to 'up' VM!
[precise] stdout: http://paste.ubuntu.com/7494631/
[precise] stderr: http://paste.ubuntu.com/7494632/
[precise] NOTE: unable to execute tests, marked as failed
[precise] Destroying failed VM to reclaim resources
[precise] Destroying VM and associated drives...
[precise] Running cleanup tasks for 'shell' provisioner...
[precise] Running cleanup tasks for 'shell' provisioner...
[trusty] Bringing VM 'up'
[trusty] Unable to 'up' VM!
[trusty] stdout: http://paste.ubuntu.com/7494635/
[trusty] stderr: http://paste.ubuntu.com/7494636/
[trusty] NOTE: unable to execute tests, marked as failed
[trusty] Destroying failed VM to reclaim resources
[trusty] Destroying VM and associated drives...
[trusty] Running cleanup tasks for 'shell' provisioner...
[trusty] Running cleanup tasks for 'shell' provisioner...

=== modified file 'checkbox-gui/checkbox-gui/qml/RunManagerView.qml'
--- checkbox-gui/checkbox-gui/qml/RunManagerView.qml	2014-05-14 14:45:02 +0000
+++ checkbox-gui/checkbox-gui/qml/RunManagerView.qml	2014-05-16 10:18:13 +0000
@@ -62,6 +62,8 @@
 
         property bool running;
 
+        property bool success;
+
         Connections {
             target: guiEngine
 
@@ -83,8 +85,8 @@
                 // update ui
                 var option_list = new Array("client-name=" + client_name);
                 var export_path = settings.value("exporter/xml_export_path", "/tmp/submission.xml")
-    
-                var success = guiEngine.GuiExportSessionToFileAsXML(export_path,
+
+                updater.success = guiEngine.GuiExportSessionToFileAsXML(export_path,
                                                                     option_list);
                 runbuttons.resultsButtonEnabled = true;
                 progress.title = i18n.tr("Completed") + "  (" + utils.formatElapsedTime((new Date() - updater.startTime)) + ")";

=== modified file 'checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml'
--- checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml	2014-05-14 13:56:59 +0000
+++ checkbox-gui/checkbox-gui/qml/SubmissionDialog.qml	2014-05-16 10:18:13 +0000
@@ -92,7 +92,7 @@
             var export_path = settings.value("exporter/xml_export_path", "/tmp/submission.xml")
 
             if (submit_to == "certification") {
-                if (success) {
+                if (updater.success) {
                     dialog.text = guiEngine.SendSubmissionViaCertificationTransport(export_path,
                                                                                     upload_input.text,
                                                                                     submit_to_hexr.checked);