Code review comment for lp:~kartiksinghal/polly/patch-for-undo-redo-for-compose-box

Revision history for this message
Conscious User (conscioususer) wrote :

Thanks again. :) Hopefully we are almost there, here's what needs fixing this time:

1) In the external __init__ file, replace "import oauth2, wraplabel" with "import oauth2, wraplabel, undobuffer"

2) For consistency, please add the "from polly.external" line as the second polly import, right above "from polly.shortener"

3) As I warned, the undo is working when you just type "z", without the Ctrl. Use Gdk.CONTROL_MASK to ensure Ctrl is pressed.

4) Also use Gdk.SHIFT_MASK to ensure shift is pressed. It's more robust than using capital "Z".

Oh, and do not make new commits just for fixing. Revert the previous commits and push the branch with --overwrite.

review: Needs Fixing

« Back to merge proposal