Merge lp:~karni/ubuntuone-android-music/playlist-caching into lp:ubuntuone-android-music

Proposed by Michał Karnicki on 2012-03-07
Status: Merged
Merged at revision: 567
Proposed branch: lp:~karni/ubuntuone-android-music/playlist-caching
Merge into: lp:ubuntuone-android-music
Diff against target: 0 lines
To merge this branch: bzr merge lp:~karni/ubuntuone-android-music/playlist-caching
Reviewer Review Type Date Requested Status
Chad Miller (community) 2012-03-07 Approve on 2012-03-20
Review via email: mp+96272@code.launchpad.net

Description of the change

This branch adds playlist prefetching and caching.

Some small part of the lines has not been changed by me, but the indentation has been corrected from tabs to spaces. *Feels really bad about indentation with spaces :/*

To post a comment you must log in.
Chad Miller (cmiller) wrote :

176 + } catch (Exception e) {
177 + Log.d(TAG, "There is no usable cache of playlists.");
178 + }

That Exception seems overly broad, especially if we're going to log it at such a low level and then discard the exception without logging what it was.

250 + Playlist playlist = (Playlist) parent.getItemAtPosition(position);

I'll bet we'll see ArrayIndexOutOfBoundsException there sometimes.

review: Approve
567. By Michał Karnicki on 2012-03-23

Applied review fixes. Secured against IndexOutOfBoundsException in case of adapter change.

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: