Merge lp:~kangol/openobject-server/6.0-cgitb into lp:openobject-server/6.0

Proposed by Christophe Simonis (OpenERP)
Status: Rejected
Rejected by: Vo Minh Thu
Proposed branch: lp:~kangol/openobject-server/6.0-cgitb
Merge into: lp:openobject-server/6.0
Diff against target: 20 lines (+2/-1)
1 file modified
bin/netsvc.py (+2/-1)
To merge this branch: bzr merge lp:~kangol/openobject-server/6.0-cgitb
Reviewer Review Type Date Requested Status
OpenERP Core Team Pending
Review via email: mp+63873@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Vo Minh Thu (thu) wrote :

Sorry, we don't accept any enhancement in stable. We will include it in trunk.

Unmerged revisions

3441. By Christophe Simonis (OpenERP)

[IMP] better traceback when reporting a uncaught exception

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/netsvc.py'
2--- bin/netsvc.py 2011-01-18 18:01:54 +0000
3+++ bin/netsvc.py 2011-06-08 14:28:31 +0000
4@@ -24,6 +24,7 @@
5 #
6 ##############################################################################
7
8+import cgitb
9 import errno
10 import logging
11 import logging.handlers
12@@ -492,7 +493,7 @@
13 except Exception, e:
14 self.log('exception', tools.exception_to_unicode(e))
15 tb = getattr(e, 'traceback', sys.exc_info())
16- tb_s = "".join(traceback.format_exception(*tb))
17+ tb_s = cgitb.text(tb)
18 if tools.config['debug_mode']:
19 import pdb
20 pdb.post_mortem(tb[2])