Merge lp:~kamyanskiy/selenium-simple-test/selenium-grid-on-jenkinds into lp:selenium-simple-test
Proposed by
Alexander Kamyanskiy
Status: | Needs review |
---|---|
Proposed branch: | lp:~kamyanskiy/selenium-simple-test/selenium-grid-on-jenkinds |
Merge into: | lp:selenium-simple-test |
Diff against target: |
45 lines (+7/-5) 2 files modified
src/sst/browsers.py (+2/-2) src/sst/scripts/remote.py (+5/-3) |
To merge this branch: | bzr merge lp:~kamyanskiy/selenium-simple-test/selenium-grid-on-jenkinds |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Vincent Ladeuil (community) | Approve | ||
Leo Arias | Pending | ||
Review via email: mp+241935@code.launchpad.net |
Commit message
Fix sst-remote runner, bug #1289990
To post a comment you must log in.
Unmerged revisions
- 441. By Alexander Kamyanskiy
-
fix misstype iself to self
- 440. By Alexander Kamyanskiy
-
add changes to fix sst-remote
Thanks for working on this !
I think the deeper issue here is that we have no regression tests for that code.
Since this improves the current situation though, we should land this fix anyway and address the testing issue in https:/ /code.launchpad .net/~canonical -platform- qa/selenium- simple- test/fix1394741 -remote_ browser_ init/+merge/ 242428