Light Display Manager

Merge lp:~kamstrup/lightdm/fix-gvariant-refs into lp:lightdm

  1. fix-gvariant-refs
  2. Merge into trunk
Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Merged at revision: 1258
Proposed branch: lp:~kamstrup/lightdm/fix-gvariant-refs
Merge into: lp:lightdm
Diff against target: 13 lines (+2/-1)
1 file modified
src/session.c (+2/-1)
To merge this branch: bzr merge lp:~kamstrup/lightdm/fix-gvariant-refs
Reviewer Review Type Date Requested Status
LightDM Development Team Pending
Review via email: mp+78574@code.launchpad.net

Description of the change

See attached bug. With this patch I can no longer reproduce it. It was a bug in the floating ref count of the variants pushed into session_set_console_kit_parameter() in session.c.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks so much Mikkel!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/session.c'
2--- src/session.c 2011-10-06 03:50:32 +0000
3+++ src/session.c 2011-10-07 11:50:22 +0000
4@@ -187,7 +187,8 @@
5 g_return_if_fail (session != NULL);
6 g_return_if_fail (name != NULL);
7
8- g_hash_table_insert (session->priv->console_kit_parameters, g_strdup (name), value);
9+ g_hash_table_insert (session->priv->console_kit_parameters,
10+ g_strdup (name), g_variant_ref_sink (value));
11 }
12
13 const gchar *

Subscribers

People subscribed via source and target branches