dee

Merge lp:~kamstrup/dee/transactions into lp:dee

Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Approved by: Michal Hruby
Approved revision: 351
Merged at revision: 321
Proposed branch: lp:~kamstrup/dee/transactions
Merge into: lp:dee
Diff against target: 0 lines
To merge this branch: bzr merge lp:~kamstrup/dee/transactions
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+85484@code.launchpad.net

Description of the change

Implement transaction logic for DeeModels in DeeTransaction

This branch implements a new class, DeeTransaction, that implements
transaction isolation on top of any old DeeModel implementation. It
has only one interesting API call so far,namely commit() which does
as labeled.

How/if exactly we want to expose a transactional API on DeeModel itself
is still up in the air; but this work should provide a solid foundation
for that. (and all of the trickier code needed, anything else will be
mostly just gloss).

Since this is a rather complicated afair I recomment that we take a somewhat
functional approach to the review. Validate the testing harness - and possibly
submit a few new test cases to cover the stuff I didn't think of.

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

One minor thing:
DEE_TRANSACTION_ERROR_COMMITED -> DEE_TRANSACTION_ERROR_COMMITTED (double T)

Revision history for this message
Michal Hruby (mhr3) wrote :

I don't see anything wrong here, so I'll approve this and we can do more tests once it's in trunk. It's nicely isolated anyway...

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

Attempt to merge into lp:dee failed due to conflicts:

text conflict in dee/Makefile.am

lp:~kamstrup/dee/transactions updated
351. By Mikkel Kamstrup Erlandsen

Sync with trunk

Preview Diff

Empty

Subscribers

People subscribed via source and target branches