Code review comment for lp:~kamstrup/dee/signal-by-id

Revision history for this message
Michal Hruby (mhr3) wrote :

> Totally agreed, that was a pretty braindead way of doing this :-)

I think that you actually thought about it quite a lot the first time ;) Doing g_signal_lookup during class_init of the type you're looking up does sound very racy, I'm actually surprised that it works.

The question is if we're going to assume that will continue working / move it to instance_init (with a GOnce guard) / or just use what was in r320.

review: Needs Information

« Back to merge proposal