dee

Merge lp:~kamstrup/dee/bug-905463 into lp:dee

  1. bug-905463
  2. Merge into trunk
Proposed by Mikkel Kamstrup Erlandsen
Status: Merged
Approved by: Michal Hruby
Approved revision: 327
Merged at revision: 333
Proposed branch: lp:~kamstrup/dee/bug-905463
Merge into: lp:dee
Diff against target: 11 lines (+1/-0)
1 file modified
dee/dee-shared-model.c (+1/-0)
To merge this branch: bzr merge lp:~kamstrup/dee/bug-905463
Reviewer Review Type Date Requested Status
Michal Hruby (community) Approve
Review via email: mp+87243@code.launchpad.net

Description of the change

Fix bug 905463 reported by coverity. Possible crasher in DeeSharedModel when constructed without a swarm name

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

Should be it safer, although there were g_return_if_fail checks down the road...

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dee/dee-shared-model.c'
2--- dee/dee-shared-model.c 2011-12-16 13:01:10 +0000
3+++ dee/dee-shared-model.c 2012-01-02 12:15:34 +0000
4@@ -608,6 +608,7 @@
5 {
6 g_critical ("You must create a DeeSharedModel with a DeePeer "
7 "in the 'peer' property");
8+ return;
9 }
10
11 /* Create a canonical object path from the well known swarm name */

Subscribers

People subscribed via source and target branches