Code review comment for lp:~kampka/ubuntu/quantal/lxc/upstart-instance

Revision history for this message
James Hunt (jamesodhunt) wrote :

Just a couple of points:

- It would be extremely useful if you added a 'usage' stanza to allow admins to see how to run the lxc-instance job as currently, if you forget to specify it, the job does nothing, silently.

  For example, add something like:

  usage "NAME=name of LXC instance, CONFIG=full path to configuration file"

  See http://upstart.ubuntu.com/cookbook/#usage

- Shouldn't that 'stop on' condition be 'stop on stopping lxc' ('stopping' rather than 'stopped')?

« Back to merge proposal